fix: wd-loadmore组件props 属性errorText默认值导致国际化失效

[emoicu]

🤔 这个 PR 的性质是？(至少选择一个)

• 日常 bug 修复
• 新特性提交
• 站点、文档改进
• 演示代码改进
• 组件样式/交互改进
• TypeScript 定义更新
• CI/CD 改进
• 包体积优化
• 性能优化
• 功能增强
• 国际化改进
• 代码重构
• 代码风格优化
• 测试用例
• 分支合并
• 其他改动（是关于什么的改动？）

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

• 文档已补充或无须补充
• 代码演示已提供或无须提供
• TypeScript 定义已补充或无须补充

Summary by CodeRabbit

• 新功能
  • 允许用户自定义加载失败时的错误信息，提高组件的灵活性和可配置性。
• 改进
  • 简化错误处理逻辑，提升可读性和效率，确保错误信息的显示更加直观。

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
wot-design-uni	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 11, 2024 6:04am

[coderabbitai]

Walkthrough

此次更改主要涉及wd-loadmore组件的错误处理逻辑和属性类型。errorText属性的类型从默认字符串值更改为更通用的字符串类型，允许用户自定义错误消息。同时，wd-loadmore.vue组件中的错误状态渲染逻辑进行了简化，减少了条件块的数量，使得错误消息的显示更加直接和清晰。

Changes

文件路径	更改摘要
src/uni_modules/wot-design-uni/components/wd-loadmore/types.ts	修改loadmoreProps中的errorText属性类型，从默认字符串值更改为字符串类型。
src/uni_modules/wot-design-uni/components/wd-loadmore/wd-loadmore.vue	简化错误状态渲染逻辑，将错误消息的显示合并为单个块，减少了条件块的数量。

Poem

🐰 在草地上跳跃的兔子，
看到变化真是开心，
错误消息更灵活，
组件更清晰可见，
让用户自定义，
体验更佳如春天，
一起欢庆这美好时光！ 🌸

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between efcd4bb and 194712b.

Files selected for processing (2)

• src/uni_modules/wot-design-uni/components/wd-loadmore/types.ts (1 hunks)
• src/uni_modules/wot-design-uni/components/wd-loadmore/wd-loadmore.vue (1 hunks)

Additional comments not posted (2)

src/uni_modules/wot-design-uni/components/wd-loadmore/types.ts (1)

23-23: 修改已批准。

将 errorText 属性类型从固定的默认字符串值更改为通用的字符串类型，可以提高组件的灵活性和可配置性，允许用户自定义错误消息。这个修改与 PR 目标一致，即修复默认值导致的国际化问题。

src/uni_modules/wot-design-uni/components/wd-loadmore/wd-loadmore.vue (1)

5-7: 修改已批准。

简化错误处理逻辑，减少条件块的数量，可以提高组件的清晰度和效率。现在，errorText 直接显示，如果未提供 errorText，则回退到翻译后的错误消息。重试文本和刷新图标保持不变，但它们的位置现在更加直接，紧跟在错误消息之后。这个修改与 PR 目标一致，即修复默认值导致的国际化问题。

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for wot-design-uni ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	194712b
🔍 Latest deploy log	https://app.netlify.com/sites/wot-design-uni/deploys/66e132a0ca74f100082ab576
😎 Deploy Preview	https://deploy-preview-594--wot-design-uni.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Moonofweisheng]

存在errorText时没必要把重试和图标给去掉吧。可以参考这个实现一下：

const placeholderValue = computed(() => {
  return isDef(props.placeholder) ? props.placeholder : translate('placeholder')
})

[emoicu]

存在errorText时没必要把重试和图标给去掉吧。可以参考这个实现一下：

const placeholderValue = computed(() => {
  return isDef(props.placeholder) ? props.placeholder : translate('placeholder')
})

没有去掉重试和图标

<text class="wd-loadmore__text">{{ errorText || translate('error') }} </text>
<text class="wd-loadmore__text is-light">{{ translate('retry') }}</text>
<wd-icon name="refresh" custom-class="wd-loadmore__refresh" />

[Moonofweisheng]

存在errorText时没必要把重试和图标给去掉吧。可以参考这个实现一下：

const placeholderValue = computed(() => {
  return isDef(props.placeholder) ? props.placeholder : translate('placeholder')
})

没有去掉重试和图标

<text class="wd-loadmore__text">{{ errorText || translate('error') }} </text>
<text class="wd-loadmore__text is-light">{{ translate('retry') }}</text>
<wd-icon name="refresh" custom-class="wd-loadmore__refresh" />

ok，ok。

[Moonofweisheng]

感谢你的PR！