Skip to content

feat: ✨ Img组件新增属性 show-menu-by-longpress 支持微信小程序长按弹出菜单栏#613

Merged
Moonofweisheng merged 1 commit into
masterfrom
feature/image-longpress
Sep 20, 2024
Merged

feat: ✨ Img组件新增属性 show-menu-by-longpress 支持微信小程序长按弹出菜单栏#613
Moonofweisheng merged 1 commit into
masterfrom
feature/image-longpress

Conversation

@Moonofweisheng
Copy link
Copy Markdown
Owner

@Moonofweisheng Moonofweisheng commented Sep 19, 2024

Closes: #611

🤔 这个 PR 的性质是?(至少选择一个)

  • 日常 bug 修复
  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • CI/CD 改进
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

show-menu-by-longpress boolean false 长按图片显示发送给朋友、收藏、保存图片、搜一搜、打开名片/前往群聊/打开小程序(若图片中包含对应二维码或小程序码)的菜单。 2.7.0

使用微信小程序原生支持的能力

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充

Summary by CodeRabbit

  • 新功能

    • wd-img 组件中添加了 showMenuByLongpress 属性,允许用户通过长按图像显示菜单,适用于微信小程序平台。
    • 增强了 <wd-img> 组件的功能,支持长按手势以提供更多用户交互选项。
  • 文档

    • 更新了 wd-img 组件的文档,进行了格式和排版的修正,提高了可读性和专业性。

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wot-design-uni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 3:41pm

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 19, 2024

Walkthrough

本次更改主要集中在 wd-img 组件的文档和类型定义上。文档中进行了格式和排版的修正,提升了可读性。同时,在类型定义中新增了 showMenuByLongpress 属性,允许在微信小程序中通过长按图片显示菜单。最后,组件的实现中也添加了相应的属性绑定,以支持这一新功能。

Changes

文件路径 更改摘要
docs/component/img.md 格式和排版修正,提高文档一致性和可读性。
src/uni_modules/wot-design-uni/components/wd-img/types.ts imgProps 中新增 showMenuByLongpress 属性,默认值为 false
src/uni_modules/wot-design-uni/components/wd-img/wd-img.vue <wd-img> 组件中添加 :show-menu-by-longpress 属性绑定,支持长按手势的功能。

Assessment against linked issues

Objective Addressed Explanation
长按图片显示菜单(#611
新增 show-menu-by-longpress 属性(#611

Possibly related PRs

Poem

🐰 在草地上跳跃,欢快无比,
新功能来临,长按不再迷。
菜单一现,选择随心,
图片互动,乐趣无穷尽!
兔子欢呼,代码更精致,
感谢开发,真是太厉害! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 19, 2024

Deploy Preview for wot-design-uni ready!

Name Link
🔨 Latest commit aa7bf4b
🔍 Latest deploy log https://app.netlify.com/sites/wot-design-uni/deploys/66ec4631a474290008ae56a7
😎 Deploy Preview https://deploy-preview-613--wot-design-uni.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying wot-design-uni with  Cloudflare Pages  Cloudflare Pages

Latest commit: aa7bf4b
Status:🚫  Build failed.

View logs

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
src/uni_modules/wot-design-uni/components/wd-img/wd-img.vue (1)

8-8: 属性绑定正确,增强了用户交互体验。

添加 :show-menu-by-longpress 属性以支持在微信小程序中通过长按图片显示菜单的功能,这是一个很好的改进。它利用了微信小程序的原生能力,为用户提供了更便捷的操作方式。

建议:

  1. 更新文档,清晰地解释这个新功能及其用法,以便开发者能够正确使用。
  2. 在文档中添加一个提示,说明该功能需要在微信小程序环境中才能生效,以避免在其他平台上使用时产生混淆。
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a51204b and aa7bf4b.

Files selected for processing (3)
  • docs/component/img.md (3 hunks)
  • src/uni_modules/wot-design-uni/components/wd-img/types.ts (1 hunks)
  • src/uni_modules/wot-design-uni/components/wd-img/wd-img.vue (1 hunks)
Files skipped from review due to trivial changes (1)
  • docs/component/img.md
Additional comments not posted (1)
src/uni_modules/wot-design-uni/components/wd-img/types.ts (1)

52-56: 代码看起来不错!

新增的 showMenuByLongpress 属性符合 PR 的目标,为微信小程序平台上的图片组件提供了长按显示菜单的功能支持。属性名称清晰明了,默认值为 false,可以避免对现有用户产生意外影响。同时,注释也清楚地说明了该属性的作用和平台限制。

总的来说,这个改动是合理且有益的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[新功能需求] 微信小程序image新增属性 show-menu-by-longpress 长按弹出菜单栏

1 participant