fix rowHeight type#682
Conversation
fix rowHeight type
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Walkthrough本次更改涉及 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for wot-design-uni ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/uni_modules/wot-design-uni/components/wd-table/types.ts (1)
36-36: rowHeight 类型定义优化合理!将
rowHeight的类型从makeNumberProp改为makeNumericProp是一个很好的改进:
- 更灵活地支持数字和字符串形式的数值
- 保持了默认值 50 不变
- 符合常见 UI 组件库的最佳实践
建议在组件文档中说明
rowHeight现在支持数字和字符串形式的输入,方便使用者了解这个改动。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- src/uni_modules/wot-design-uni/components/wd-table/types.ts (2 hunks)
🔇 Additional comments (1)
src/uni_modules/wot-design-uni/components/wd-table/types.ts (1)
11-11: 导入声明更新正确!导入声明已正确更新,以支持新的类型定义。
fix rowHeight type
🤔 这个 PR 的性质是?(至少选择一个)
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit