fix: 🐛 修复 vue-tsc 校验不通过的问题 by Moonofweisheng · Pull Request #753 · Moonofweisheng/wot-design-uni

Moonofweisheng · 2024-12-03T07:36:31Z

✅ Closes: #752

🤔 这个 PR 的性质是？(至少选择一个)

🔗 相关 Issue

#752

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

文档已补充或无须补充
代码演示已提供或无须提供
TypeScript 定义已补充或无须补充

Summary by CodeRabbit

新功能
- 增强了浮动操作按钮（FAB）的交互模型，确保其根据用户输入和属性值正确响应。
- FAB 组件现在支持通过 active 属性动态控制其活动状态。
改进
- 更新了 isH5 常量的定义，使其在运行时根据编译上下文动态确定。
- 改进了 FAB 的点击事件处理，确保在禁用状态下不触发事件。
类型安全
- 更新了进度组件中的 timer 变量类型，提高了类型安全性。

✅ Closes: #752

vercel · 2024-12-03T07:36:36Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
wot-design-uni	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 3, 2024 7:37am

coderabbitai · 2024-12-03T07:36:39Z

Walkthrough

本次更改涉及三个主要组件的更新。首先，util.ts 文件中的 isH5 常量的定义已被修改为使用立即调用函数表达式（IIFE），以便根据编译上下文动态确定其值。其次，wd-fab.vue 组件增强了浮动操作按钮的可见性和交互性，新增了处理活动状态的逻辑，并改进了事件处理。最后，wd-progress.vue 组件更新了 timer 变量的类型定义，以增强类型安全性。

Changes

文件路径	更改摘要
`src/uni_modules/wot-design-uni/components/common/util.ts`	将 `isH5` 的定义从简单布尔表达式更改为立即调用函数表达式（IIFE），以便根据编译上下文动态设置其值。
`src/uni_modules/wot-design-uni/components/wd-fab/wd-fab.vue`	添加了 FAB 的可见性和交互性功能，更新了 `handleClick` 函数逻辑，增强了状态管理和错误处理。
`src/uni_modules/wot-design-uni/components/wd-progress/wd-progress.vue`	将 `timer` 变量的类型从 `NodeJS.Timeout

Assessment against linked issues

Objective	Addressed	Explanation
修复 `util.ts` 中的类型错误 (#752)	✅
修复 `wd-fab.vue` 中的类型错误 (#752)	❌	仍存在类型不匹配的问题未解决。
修复 `wd-progress.vue` 中的类型错误 (#752)	✅

Possibly related issues

[Bug 上报] 安装@uni-helper/uni-typed后 wot-design-uni 报 tsc 类型校验错误 #586: 本次更改可能解决了与 TypeScript 错误相关的问题，特别是在 util.ts 中的类型定义。

Possibly related PRs

refactor: ♻️ 移除与isDef互斥的isNone #681: 涉及对 util.ts 文件的修改，可能与本次 PR 的更改相关。
refactor: ♻️ 重构Input、Textarea组件的事件执行时序 #493: 同样修改了 util.ts 文件，涉及实用函数的重大更改，可能影响整体功能。
fix: 🐛 修复Textarea的placeholder无法设置空字符串问题 #472: 尽管主要集中在 wd-textarea 组件，但可能间接影响 util.ts 文件中的函数使用。
fix: 🐛 修复Collapse折叠面板组件内容溢出问题 #710: 解决了 wd-collapse-item 组件中的一个错误，可能与本次 PR 的更改有关。
fix: 🐛 修复 Collapse v-model绑定数据变化时未更新折叠面板状态的问题 #744: 关注 Collapse 组件，可能受到本次 PR 中实用函数更改的影响。

Poem

🐰 在月光下轻轻跳跃，
新功能如星星闪耀。
按钮活跃又可爱，
代码更稳如山高。
兔子欢呼声不断，
变化带来新希望！ 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between e9b147e and 05cdfa6.

📒 Files selected for processing (3)

src/uni_modules/wot-design-uni/components/common/util.ts (1 hunks)
src/uni_modules/wot-design-uni/components/wd-fab/wd-fab.vue (0 hunks)
src/uni_modules/wot-design-uni/components/wd-progress/wd-progress.vue (1 hunks)

💤 Files with no reviewable changes (1)

src/uni_modules/wot-design-uni/components/wd-fab/wd-fab.vue

🔇 Additional comments (2)

src/uni_modules/wot-design-uni/components/wd-progress/wd-progress.vue (1)

37-37: 类型定义改进已确认!

将 timer 变量的类型从 NodeJS.Timeout | null 更改为 ReturnType<typeof setTimeout> | null 是一个很好的改进。这个改动：

提供了更准确的类型定义
避免了对 NodeJS 类型的依赖
使代码更具可移植性

src/uni_modules/wot-design-uni/components/common/util.ts (1)

698-704: 平台检测实现优化已确认!

使用条件编译指令（#ifdef H5）替代 process.env 检查是一个很好的改进：

更可靠的平台检测机制
利用了 uni-app 的内置功能
通过 IIFE 确保值只计算一次

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2024-12-03T07:36:48Z

✅ Deploy Preview for wot-design-uni ready!

Name	Link
🔨 Latest commit	`05cdfa6`
🔍 Latest deploy log	https://app.netlify.com/sites/wot-design-uni/deploys/674eb502ae0cee0008fe5cc2
😎 Deploy Preview	https://deploy-preview-753--wot-design-uni.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages · 2024-12-03T07:37:45Z

Deploying wot-design-uni with Cloudflare Pages

Latest commit:	`05cdfa6`
Status:	✅ Deploy successful!
Preview URL:	https://41192978.wot-design-uni.pages.dev
Branch Preview URL:	https://fix-vue-tsc.wot-design-uni.pages.dev

View logs

fix: 🐛 修复 vue-tsc 校验不通过的问题

05cdfa6

✅ Closes: #752

vercel Bot deployed to Preview December 3, 2024 07:37 View deployment

Moonofweisheng merged commit a90f4ad into master Dec 3, 2024

coderabbitai Bot mentioned this pull request Dec 5, 2024

feat: ✨ MessageBox 新增确认、取消按钮的 ButtonProps 属性 #761

Merged

19 tasks

coderabbitai Bot mentioned this pull request Mar 11, 2025

Fix wd-picker empty columns issue and extend wd-fab with new positions #938

Merged

19 tasks

Moonofweisheng deleted the fix/vue-tsc branch March 25, 2025 15:08

coderabbitai Bot mentioned this pull request Sep 25, 2025

feat(wd-fab): 添加自定义位置和偏移量支持，修复关闭拖拽后，菜单弹出方向未更新回来的bug #1315

Open

19 tasks

coderabbitai Bot mentioned this pull request Oct 31, 2025

refactor: ♻️ 适配微信小程序废弃 getSystemInfo 接口的逻辑 #1348

Merged

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: 🐛 修复 vue-tsc 校验不通过的问题#753

fix: 🐛 修复 vue-tsc 校验不通过的问题#753
Moonofweisheng merged 1 commit into
masterfrom
fix/vue-tsc

Moonofweisheng commented Dec 3, 2024 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Dec 3, 2024 •

edited

Loading

Uh oh!

coderabbitai Bot commented Dec 3, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

netlify Bot commented Dec 3, 2024 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages Bot commented Dec 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Moonofweisheng commented Dec 3, 2024 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 这个 PR 的性质是？(至少选择一个)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

Summary by CodeRabbit

Uh oh!

vercel Bot commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Possibly related issues

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

netlify Bot commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for wot-design-uni ready!

Uh oh!

cloudflare-workers-and-pages Bot commented Dec 3, 2024

Deploying wot-design-uni with Cloudflare Pages

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Moonofweisheng commented Dec 3, 2024 •

edited by coderabbitai Bot

Loading

vercel Bot commented Dec 3, 2024 •

edited

Loading

coderabbitai Bot commented Dec 3, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify Bot commented Dec 3, 2024 •

edited

Loading