feat: ✨ Swiper 轮播视频支持控制静音播放和循环播放 by Moonofweisheng · Pull Request #855 · Moonofweisheng/wot-design-uni

Moonofweisheng · 2025-01-18T04:16:05Z

✅ Closes: #846

🤔 这个 PR 的性质是？(至少选择一个)

🔗 相关 Issue

#846

💡 需求背景和解决方案

添加muted和video-loop属性用于控制视频静音播放和循环播放

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

文档已补充或无须补充
代码演示已提供或无须提供
TypeScript 定义已补充或无须补充

Summary by CodeRabbit

新功能
- 为 wd-swiper 组件添加了视频播放控制选项
  - 新增 muted 属性，控制视频是否静音（默认为 true）
  - 新增 videoLoop 属性，控制视频是否循环播放（默认为 true）

✅ Closes: #846

vercel · 2025-01-18T04:16:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
wot-design-uni	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 18, 2025 4:16am

coderabbitai · 2025-01-18T04:16:19Z

概述

演练

此次更改为 wd-swiper 组件引入了两个新属性：muted（静音）和 videoLoop（视频循环）。muted 属性是一个布尔值，控制视频是否静音播放，默认为 true。videoLoop 属性也是布尔值，决定视频是否循环播放，默认为 true。这些新增属性通过文档、类型定义和组件实现进行了全面更新。

变更

文件	变更摘要
`docs/component/swiper.md`	添加 `muted` 和 `videoLoop` 属性的文档描述
`src/uni_modules/wot-design-uni/components/wd-swiper/types.ts`	在 `swiperProps` 中添加 `muted` 和 `videoLoop` 属性
`src/uni_modules/wot-design-uni/components/wd-swiper/wd-swiper.vue`	将 `<video>` 元素的 `loop` 和 `muted` 属性从隐式更改为绑定属性

对链接问题的评估

目标	是否解决	说明
轮播图视频播放支持声音 [#846]	✅

可能相关的 PR

feat: ✨ Swiper 轮播组件支持展示视频和设置轮播项标题 #663: 增强轮播图组件的视频播放支持
feat: ✨ Swiper 支持指定轮播项的文件类型 #720: 为 SwiperList 添加资源类型属性
feat: ✨ Swiper 轮播项type字段的处理逻辑限制在可选值范围内 #785: 限制 type 字段的可接受值

诗歌

🐰 轮播兔子欢蹦跳，
视频声音来解闹，
循环与静音自由选，
轮播组件新魔法，
用户体验更精妙！

Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-18T04:16:27Z

✅ Deploy Preview for wot-design-uni ready!

Name	Link
🔨 Latest commit	`32bb035`
🔍 Latest deploy log	https://app.netlify.com/sites/wot-design-uni/deploys/678b2b07c4c4de0008d54906
😎 Deploy Preview	https://deploy-preview-855--wot-design-uni.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

docs/component/swiper.md (1)
330-331: 表格格式需要修正

表格的分隔符格式不一致，建议修改如下：
-｜ muted | 视频是否静音播放 | `boolean` | - | `true` | $LOWEST_VERSION$ |
+| muted | 视频是否静音播放 | `boolean` | - | `true` | $LOWEST_VERSION$ |
🧰 Tools

🪛 Markdownlint (0.37.0)

330-330: Expected: leading_and_trailing; Actual: trailing_only; Missing leading pipe
Table pipe style

(MD055, table-pipe-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21fbfbb and 32bb035.

📒 Files selected for processing (3)

docs/component/swiper.md (1 hunks)
src/uni_modules/wot-design-uni/components/wd-swiper/types.ts (1 hunks)
src/uni_modules/wot-design-uni/components/wd-swiper/wd-swiper.vue (1 hunks)

🧰 Additional context used

🪛 Markdownlint (0.37.0)

docs/component/swiper.md

330-330: Expected: leading_and_trailing; Actual: trailing_only; Missing leading pipe
Table pipe style

(MD055, table-pipe-style)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Cloudflare Pages

🔇 Additional comments (4)

src/uni_modules/wot-design-uni/components/wd-swiper/types.ts (2)

118-124: 视频循环播放属性定义正确！

videoLoop 属性的类型定义和默认值设置合理，注释清晰完整。

125-131: 视频静音属性定义正确！

muted 属性的类型定义和默认值设置合理，注释清晰完整。

src/uni_modules/wot-design-uni/components/wd-swiper/wd-swiper.vue (1)

33-34: 视频属性绑定实现正确！

:loop="videoLoop" 和 :muted="muted" 的动态绑定实现正确，使视频的循环和静音状态可以通过属性控制。

docs/component/swiper.md (1)

330-331: 新属性文档说明完整！

muted 和 videoLoop 属性的说明清晰，包含了类型、默认值等必要信息。

🧰 Tools

🪛 Markdownlint (0.37.0)

330-330: Expected: leading_and_trailing; Actual: trailing_only; Missing leading pipe
Table pipe style

(MD055, table-pipe-style)

feat: ✨ Swiper 轮播视频支持控制静音播放和循环播放

32bb035

✅ Closes: #846

coderabbitai Bot reviewed Jan 18, 2025

View reviewed changes

Moonofweisheng merged commit 7a0d5ce into master Jan 18, 2025

Moonofweisheng deleted the feature/swiper-muted branch March 25, 2025 15:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: ✨ Swiper 轮播视频支持控制静音播放和循环播放#855

feat: ✨ Swiper 轮播视频支持控制静音播放和循环播放#855
Moonofweisheng merged 1 commit into
masterfrom
feature/swiper-muted

Moonofweisheng commented Jan 18, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Jan 18, 2025

Uh oh!

coderabbitai Bot commented Jan 18, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

netlify Bot commented Jan 18, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Moonofweisheng commented Jan 18, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 这个 PR 的性质是？(至少选择一个)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

Summary by CodeRabbit

Uh oh!

vercel Bot commented Jan 18, 2025

Uh oh!

coderabbitai Bot commented Jan 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

概述

演练

变更

对链接问题的评估

可能相关的 PR

诗歌

Finishing Touches

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

netlify Bot commented Jan 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for wot-design-uni ready!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Moonofweisheng commented Jan 18, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jan 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify Bot commented Jan 18, 2025 •

edited

Loading