Skip to content

fix: 🐛 修复 Upload 组件自定义上传方法不支持asyncfunction的问题#890

Merged
Moonofweisheng merged 1 commit into
masterfrom
fix/upload-uploadMethod-asyncfunction
Feb 12, 2025
Merged

fix: 🐛 修复 Upload 组件自定义上传方法不支持asyncfunction的问题#890
Moonofweisheng merged 1 commit into
masterfrom
fix/upload-uploadMethod-asyncfunction

Conversation

@Moonofweisheng
Copy link
Copy Markdown
Owner

@Moonofweisheng Moonofweisheng commented Feb 12, 2025

Closes: #859

🤔 这个 PR 的性质是?(至少选择一个)

  • 日常 bug 修复
  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • CI/CD 改进
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

#859

💡 需求背景和解决方案

修复 Upload 组件自定义上传方法不支持asyncfunction的问题

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充

Summary by CodeRabbit

  • New Features

    • 上传组件现在允许使用自定义异步上传方法,提升了上传流程的灵活性。
  • Refactor

    • 优化了函数类型校验逻辑,支持识别同步与异步函数。
    • 简化了上传组件中与预览、删除、上传等操作相关的错误处理流程。

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wot-design-uni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 5:53am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 12, 2025

Walkthrough

这次更新涉及三个文件的修改。首先,util.ts 中的 isFunction 函数扩展了类型检测逻辑,现在支持识别异步函数。其次,wd-upload/types.ts 中的 UploadMethod 类型更新为支持返回 void | Promise<void>,并在上传属性中添加了 uploadMethod。最后,wd-upload/wd-upload.vue 内部针对多个观察函数的错误处理进行了简化,仅检测常规函数而移除了对异步函数的冗余检查。

Changes

文件路径 修改摘要
src/uni_modules/.../common/util.ts 修改 isFunction 函数,增加对 'asyncfunction' 类型的识别。
src/uni_modules/.../wd-upload/types.ts
src/uni_modules/.../wd-upload/wd-upload.vue
更新 UploadMethod 类型以支持异步返回;简化上传组件中多个观察函数的错误处理逻辑,只校验常规函数。

Sequence Diagram(s)

sequenceDiagram
    participant U as 上传组件
    participant F as isFunction 函数
    participant M as UploadMethod 方法
    U ->> F: 检查 uploadMethod 是否为函数
    F -->> U: 返回验证结果
    alt 函数有效
        U ->> M: 调用自定义上传方法
        alt 异步上传
            M -->> U: 返回 Promise 结果
        else
            M -->> U: 同步完成
        end
    else
        U -->> U: 触发错误处理
    end
Loading

Possibly related PRs

Poem

我是一只快乐的小兔子,
跳跃在代码的花园里寻找新奇,
检测函数变得更加机敏✨,
异步上传翩然起舞轻盈,
每行代码都是跳跃的音符!
庆祝更新,享受这美好时光!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ebbe7e4 and 17e7cc7.

📒 Files selected for processing (3)
  • src/uni_modules/wot-design-uni/components/common/util.ts (1 hunks)
  • src/uni_modules/wot-design-uni/components/wd-upload/types.ts (1 hunks)
  • src/uni_modules/wot-design-uni/components/wd-upload/wd-upload.vue (6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Redirect rules - wot-design-uni
  • GitHub Check: Header rules - wot-design-uni
  • GitHub Check: Pages changed - wot-design-uni
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (8)
src/uni_modules/wot-design-uni/components/wd-upload/types.ts (1)

113-127: 类型定义更新正确!

返回类型从 void 更新为 void | Promise<void> 使得 UploadMethod 可以支持异步上传方法,同时保持了向后兼容性。

src/uni_modules/wot-design-uni/components/common/util.ts (1)

316-319: 函数类型检查逻辑优化正确!

通过检查 'function' 和 'asyncfunction' 两种类型,使得 isFunction 工具函数可以正确识别同步和异步函数,增强了类型检查的准确性。

src/uni_modules/wot-design-uni/components/wd-upload/wd-upload.vue (6)

178-189: 监听处理器简化正确!

简化了 beforePreview 的类型检查逻辑,由于更新后的 isFunction 已支持异步函数,因此移除了冗余检查是合理的。


191-202: 监听处理器简化正确!

简化了 onPreviewFail 的类型检查逻辑,保持了与其他处理器一致的验证方式。


204-215: 监听处理器简化正确!

简化了 beforeRemove 的类型检查逻辑,使代码更加简洁。


217-228: 监听处理器简化正确!

简化了 beforeUpload 的类型检查逻辑,与其他处理器保持一致的验证方式。


230-241: 监听处理器简化正确!

简化了 beforeChoose 的类型检查逻辑,使代码更加统一。


243-254: 监听处理器简化正确!

简化了 buildFormData 的类型检查逻辑,完成了所有处理器的统一优化。

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 12, 2025

Deploy Preview for wot-design-uni ready!

Name Link
🔨 Latest commit 17e7cc7
🔍 Latest deploy log https://app.netlify.com/sites/wot-design-uni/deploys/67ac374cb9476900087724f5
😎 Deploy Preview https://deploy-preview-890--wot-design-uni.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying wot-design-uni with  Cloudflare Pages  Cloudflare Pages

Latest commit: 17e7cc7
Status: ✅  Deploy successful!
Preview URL: https://f604b9e9.wot-design-uni.pages.dev
Branch Preview URL: https://fix-upload-uploadmethod-asyn.wot-design-uni.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[新功能需求] wd-upload自定义上传支持promise类型的函数

1 participant