add a test to actually round trip an entity using BigDecimal #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozza
reviewed
Dec 7, 2016
| @@ -25,7 +25,7 @@ | |||
| /** | |||
| * This provides a conversion to/from BigDecimal in applications using the Decimal128 type introduced in the 3.4.0 release of MongoDB. This | |||
| * converter also supports loading certain types of values from the database and converting them to BigDecimal. | |||
| * | |||
| * <p> | |||
There was a problem hiding this comment.
Nit: unclosed tag - I think javadoc will complain
There was a problem hiding this comment.
Ah I remember its Java 8 doclint that will complain, so it depends on which version you are using to build the javadoc and / or you have disabled doclint.
|
|
||
| import static java.lang.String.format; | ||
|
|
||
| class ConverterTest<F, T> { | ||
| class ConverterTest<F, T> extends TestBase { |
There was a problem hiding this comment.
You probably should also add round trip test cases for your other ConverterTests to prevent future regressions.
jyemin
suggested changes
Dec 7, 2016
| /** | ||
| * Creates the Converter. | ||
| */ | ||
| public BigDecimalConverter() { |
There was a problem hiding this comment.
Let's unit test this constructor, and other similar converters.
There was a problem hiding this comment.
I'll update the commit message on the merge commit...
|
Good to merge? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃う
fixes #1093