-
Notifications
You must be signed in to change notification settings - Fork 179
Conversation
of construct/lib/binary.py to allow its tests to pass
…t code closer to PEP-8
…is still commented out
…bed it in other libraries
hi @eliben -- i applied you patch to https://github.com/construct/construct (where construct is now being developed) |
Hi Tomer, On Tue, May 15, 2012 at 10:53 PM, Tomer Filiba
|
Allow the Pointer to relocate relative to EOF
Hi Corbin,
This is construct modified to run under Python 3 as well as Python 2, in the same code base. Specifically, both of the following test runs are succeeding:
Regarding what this means for construct - it doesn't mean parsing Unicode. construct is for parsing byte streams, so the changes are solely for the purpose of making it run at all on Python 3.
I agree completely that text/unicode parsing is not the focus of construct, and would even go as far as to remove the current very partial and incomplete support construct has for text parsing. This is ultimately your decision of course.
Feel free to ask me any questions/details about the pull request. It's a pretty straightforward port to a python 2/3 portable code, really.