GitHub image preview: better compatibility with other extensions #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidonng
commented
Jul 16, 2022
| // not every submodule includes a link; reference examples from | ||
| // see https://github.com/electron/electron/tree/v1.1.1/vendor | ||
| const el = $("a", row) || $("div[role='rowheader'] span[title]", row); | ||
| const el = $("div[role='rowheader'] a, div[role='rowheader'] span[title]", row); |
Contributor
Author
There was a problem hiding this comment.
This is the one line fix for Refined GitHub
kidonng
commented
Jul 16, 2022
Comment on lines
-231
to
-239
| const str = url.substring(url.lastIndexOf("/") + 1, url.length); | ||
| // don't include extension for folders, or files with no extension, | ||
| // or files starting with a "." (e.g. ".gitignore") | ||
| content += (!noExt && str.indexOf(".") > 0) ? | ||
| "<h4 class='ghip-file-type'>" + | ||
| str | ||
| .substring(str.lastIndexOf(".") + 1, str.length) | ||
| .toUpperCase() + | ||
| "</h4></span>" : "</span>"; |
Contributor
Author
There was a problem hiding this comment.
This does not look good with file icon extensions, so I dropped it. However, it makes it a little worse for those who don't use them. I believe the tradeoff is worth it, let me know your thoughts.
Owner
There was a problem hiding this comment.
Yeah, I think you're right.. I'm going to go ahead and merge your work, but I'm going to tweak it a bit to show the full file name. Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found this script and it works like charm! I mean, without other extensions in the way...
This pull request fixes some compatibility issues with other browser extensions:
quick-file-editfeature, which is a one line fixNow icons look good in dark mode:
With https://github.com/Claudiohbsantos/github-material-icons-extension:
I'm aiming for a minimal diff in case you want to argue about e.g. the variable name a little bit.