Cannot return to input if usePreview: false and lockInput : true #77

Closed
jdaniells opened this Issue Jun 15, 2012 · 4 comments

Comments

Projects
None yet
2 participants

If I have a keyboard with

usePreview: false
lockInput : true

once I have abandoned the input text, I cannot return to it.

I think the problem is that the attribute readonly is added to the input text and not removed after closing the keyboard.

I fixed it adding this lines:

if (o.lockInput && !o.usePreview) {
base.$el.removeAttr("readonly");
}

Inside the following block in base.close function:
if (!o.alwaysOpen) {
base.$keyboard.hide();
base.isVisible = false;
if (o.lockInput && !o.usePreview) {
base.$el.removeAttr("readonly");
}
}

Owner

Mottie commented Jun 15, 2012

Hi jdaniells!

Thanks for reporting this issue and helping find the problem! I'll try to find time to look into this soon. :)

Mottie added a commit that referenced this issue Jun 17, 2012

Owner

Mottie commented Jun 18, 2012

Hi jdaniells!

This should now be fixed in version 1.9.19! I appreciate the code fixes! :)

Owner

Mottie commented Jul 2, 2012

I'm guessing this issue has been resolved, so I'm going to close it. Please feel free to reopen it if you continue to have problems. Thanks!

@Mottie Mottie closed this Jul 2, 2012

Hi Rob!

Yes it is fixed!

Thanks.

2012/7/2 Rob G <
reply@reply.github.com

I'm guessing this issue has been resolved, so I'm going to close it.
Please feel free to reopen it if you continue to have problems. Thanks!


Reply to this email directly or view it on GitHub:
#77 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment