Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

viet.js #136

Merged
merged 1 commit into from Mar 29, 2013

Conversation

Projects
None yet
2 participants
Contributor

tbvinh commented Jan 30, 2013

Bản quyền thuộc về Vinh Can Code

@tbvinh tbvinh Create viet.js
Bản quyền thuộc về Vinh Can Code
87e6461
Owner

Mottie commented Feb 12, 2013

Hi tbvinh!

Thanks for contributing to this repository! I haven't merged in this pull request because I'm not clear on what the extensive key combos (lines 71+) are supposed to do. I think the key combinations of "u+s", "u+r", etc are much too common to be forcing into a combo. Can you explain a bit more please?

Contributor

tbvinh commented Feb 17, 2013

Hi Rob,
Thank you very much. I just went back from vacation.

I need some characters with Telex inputing method: u+s => ú, u+r => ủ
U+r/R => Ủ

My full name: Trần Bá Vinh. You see: a+a+f => ầ , a+s ==> á

There are some ways to input Vietnamese characters, and I choose Telex.

http://vietunicode.sourceforge.net/inputmethod.html
http://en.wikipedia.org/wiki/Telex_(IME)
http://en.wikipedia.org/wiki/Vietnamese_alphabet

Cheers,
Vinh

PS: In the future, when you are in VN please contact me.

On Tue, Feb 12, 2013 at 9:58 PM, Rob G notifications@github.com wrote:

Hi tbvinh!

Thanks for contributing to this repository! I haven't merged in this pull
request because I'm not clear on what the extensive key comboshttps://github.com/tbvinh/Keyboard/commit/87e6461945a9305e7c4e7068d788ebee6149e044#L0R71(lines 71+) are supposed to do. I think the key combinations of "u+s",
"u+r", etc are much too common to be forcing into a combo. Can you explain
a bit more please?


Reply to this email directly or view it on GitHubhttps://github.com/Mottie/Keyboard/pull/136#issuecomment-13435978.

Owner

Mottie commented Mar 13, 2013

Hi Vinh!

The reason I haven't merged this pull request yet is that I tried out some of the Telex inputs shown on this page and it doesn't seem to work when I input some of the "Tone markings" examples. I just wasn't sure if that was a big deal or not.

Thanks!

Contributor

tbvinh commented Mar 14, 2013

Hi Rob,

I create Telex Input base on http://en.wikipedia.org/wiki/Telex_(IME)
So you can try some "Tone markings" directly.

Instead of input huyeenf ==> huyền
we can input: huyeefn ==> huyền.
The tone must input after vowel (u i o e y a) and Non-tonal diacritics
I don't now how to implement the Tone input at the end of word
_huyeenf_huyền
Similar: sawsc => sắc.

Thanks,
Vinh

On Thu, Mar 14, 2013 at 1:38 AM, Rob G notifications@github.com wrote:

Hi Vinh!

The reason I haven't merged this pull request yet is that I tried out some
of the Telex inputs shown on this pagehttp://en.wikipedia.org/wiki/Telex_(IME)
and it doesn't seem to work when I input some of the "Tone markings"
examples. I just wasn't sure if that was a big deal or not.

Thanks!


Reply to this email directly or view it on GitHubhttps://github.com/Mottie/Keyboard/pull/136#issuecomment-14860445
.

@Mottie Mottie added a commit that referenced this pull request Mar 29, 2013

@Mottie Mottie Merge pull request #136 from tbvinh/patch-1
viet.js
fd16331

@Mottie Mottie merged commit fd16331 into Mottie:master Mar 29, 2013

Owner

Mottie commented Mar 29, 2013

Thanks! Sorry for taking so long to merge.

@Mottie Mottie added a commit that referenced this pull request Mar 29, 2013

@Mottie Mottie Fixed & cleaned up Vietnamese layout. See #136 6be87e2
Owner

Mottie commented Mar 29, 2013

I ended up adding an "alt-shift" keyset and rearranging a few keys. Thanks again for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment