filter widget 2.3, using class "filter-false" doesn't work anymore

[vertigo235]

worked fine with 2.1

[Mottie]

Please make sure you are using the latest version. Version 2.3 was a bit buggy.

[vertigo235]

yes, the version dated 5/11

[vertigo235]

it looks like a commit on 5/9 I think might have removed the check for the class?

[vertigo235]

This change?

fr += ((c.headers[i] && c.headers[i].hasOwnProperty('filter') && c.headers[i].filter === false) || $(c.headerList[i]).is('.filter-false') ) ? ' disabled" disabled' : '"'; 

to

fr += $.tablesorter.getData(c.headerList[i], c.headers[i], 'filter') === 'false' ? ' disabled" disabled' : '"'; 

[Mottie]

Ok, I found the problem... yes, it was in that code. And also I should note that the above change also makes the filter widget not compatible with the original tablesorter plugin.... I'll add a comment in the latest update, but maybe I should include a patch so it will work?

[Mottie]

Ok this problem has been fixed in v2.3.3. Thanks for reporting it.

[vertigo235]

Thanks I'll check it out! I really appreciate all the hard work you do on this amazing plugin.

Thanks again.

On May 19, 2012, at 4:48 PM, Rob Greply@reply.github.com wrote:

Ok this problem has been fixed in v2.3.3. Thanks for reporting it.

---

Reply to this email directly or view it on GitHub:
#73 (comment)

[Mottie]

Thanks! And actually, I modified the widget after I posted the message above... the filter widget is still backwards compatible with v2.0.5... it's just that the older version won't work with jQuery data settings.