From 5f011c4043e484507409b2a5fe3626984a74d677 Mon Sep 17 00:00:00 2001 From: Wim Selles Date: Tue, 7 May 2019 10:34:07 +0200 Subject: [PATCH] Fix determining w3c for browserstack (#3936) * feat: add RDC API to service - update test * fix: support proper W3C for BrowserStack This PR fixes https://github.com/webdriverio/webdriverio/issues/3935 --- packages/webdriver/src/utils.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/webdriver/src/utils.js b/packages/webdriver/src/utils.js index e2fd823b467..a714b68556f 100644 --- a/packages/webdriver/src/utils.js +++ b/packages/webdriver/src/utils.js @@ -210,10 +210,10 @@ export function isW3C (capabilities) { capabilities.platformName && capabilities.browserVersion && /** - * local safari doesn't provide platformVersion therefor - * check also for setWindowRect + * local safari and BrowserStack don't provide platformVersion therefor + * check also if setWindowRect is provided */ - (capabilities.platformVersion || capabilities.setWindowRect) + (capabilities.platformVersion || capabilities.hasOwnProperty('setWindowRect')) ) return Boolean(hasW3CCaps || isAppium) }