From e8bfd25c8b8b5fdd4165c9daa7e2cc3960c48174 Mon Sep 17 00:00:00 2001 From: Christian Bromann Date: Tue, 23 Apr 2019 16:06:07 -0500 Subject: [PATCH] Don't fail element command in IE (#3874) --- packages/webdriver/src/utils.js | 15 ++++++++++----- packages/webdriver/tests/utils.test.js | 4 ++++ 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/packages/webdriver/src/utils.js b/packages/webdriver/src/utils.js index 7e4b3ebaa16..e2fd823b467 100644 --- a/packages/webdriver/src/utils.js +++ b/packages/webdriver/src/utils.js @@ -28,11 +28,16 @@ export function isSuccessfulResponse (statusCode, body) { /** * ignore failing element request to enable lazy loading capability */ - if (body.status && body.status === 7 && body.value && body.value.message && - (body.value.message.toLowerCase().startsWith('no such element') || - //Appium - body.value.message === - 'An element could not be located on the page using the given search parameters.')) { + if ( + body.status === 7 && body.value && body.value.message && + ( + body.value.message.toLowerCase().startsWith('no such element') || + // Appium + body.value.message === 'An element could not be located on the page using the given search parameters.' || + // Internet Explorter + body.value.message.toLowerCase().startsWith('unable to find element') + ) + ) { return true } diff --git a/packages/webdriver/tests/utils.test.js b/packages/webdriver/tests/utils.test.js index c7f4bbac3b8..53a75096f49 100644 --- a/packages/webdriver/tests/utils.test.js +++ b/packages/webdriver/tests/utils.test.js @@ -27,6 +27,10 @@ describe('utils', () => { undefined, { status: 7, value: { message: 'no such element: foobar' } } )).toBe(true) + expect(isSuccessfulResponse( + 200, + { value: { message: 'Unable to find element with xpath == //foobar' } } + )).toBe(true) }) it('isValidParameter', () => {