Repository navigation
force/contact handling - #516
Merged
Merged
Conversation
IsaacLic
marked this pull request as draft
June 5, 2020 22:55
NicholasBatesNZ
requested changes
Jun 7, 2020
NicholasBatesNZ
left a comment
NicholasBatesNZ
left a comment
Member
There was a problem hiding this comment.
Good stuff. Nice amount of javadocs too but I feel that they could be a bit more explanatory at times :)
Adrijaned
reviewed
Jun 7, 2020
Co-authored-by: Jindřich Dítě <adrijaned@gmail.com>
I did most of the changes that were suggested, but I haven't looked into the usage of `causesAcceleration` or why impulse is currently a float, so I didn't make those changes yet.
syntaxi
reviewed
Jun 8, 2020
syntaxi
left a comment
syntaxi
left a comment
There was a problem hiding this comment.
Looks good overall, just some clarification on how the things will be used
IsaacLic
marked this pull request as ready for review
June 14, 2020 21:46
NicholasBatesNZ
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles the contact between two entities and the application of force to any entity. When two objects collide, a
ContactEventis created which, depending on how it is handled, can then create aForceEvent.