Loot dropping upon death#529
Merged
NicholasBatesNZ merged 6 commits intoMovingBlocks:developfrom Jul 21, 2020
Merged
Conversation
NicholasBatesNZ
requested changes
Jul 10, 2020
engine/src/main/java/org/destinationsol/loot/systems/LootDroppingSystem.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/destinationsol/loot/systems/LootDroppingSystem.java
Outdated
Show resolved
Hide resolved
Member
|
I read "loot dropping" I post links:
These are basically two resources I found while briefly looking into loot tables for Terasology. Maybe they are helpful, maybe not - I honestly didn't look at the PR 🙈 |
NicholasBatesNZ
approved these changes
Jul 21, 2020
Member
NicholasBatesNZ
left a comment
There was a problem hiding this comment.
Sorry for the delay on this, seems to work 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a system for creating
Lootobjects when an entity with aDropsLootcomponent dies.Lootis the DS object that is created when certainSolObjects (e.g. ships) are destroyed. The logic was pulled fromAsteroid, althoughSolShipuses a similar structure.This is built upon PRs #519 and #522. It makes use of the
DestroyEventfrom 519, as well asPositionandVelocityfrom 522.Testing
First, copy/paste the following three fields to SolApplication:
Next, add the following code after line 231 (inside the
ifstatement that confims thatsolGameisn't null):That code does a few things:
EntitySystemManagerwill send aDestroyEventto the entity, causing loot to appear on screen