Initial SolarSystemGenerator design #597

IsaiahBlanks · 2021-06-23T14:59:44Z

Description

This PR defines some initial sections of the SolarSystemGenerator class. This class is an abstract class that will handle much of the logic behind SolarSystem generation. So far, this code creates placements for SolarSystems and Mazes, and generates the correct number of SolarSystemGenerators, MazeGenerators, and PlanetGenerators.

Testing

When you run the game, you will see print statements describing what position has been set for each generator created (these do not show up in the actual game yet).

Design Questions

I'm not sure about my use of Class variable to instantiate new Maze and Planet generators in the SolarSystemGenerator class. Previously, the code just called featureGenerator.build() on each available FeatureGenerator. The issue with this is that each FeatureGenerator actually needs to be initialized as it's own object, instead of being a reference to the one is the list (So that they can each have their own position, size, etc.). However, I'm unsure if this is the best way to handle that.
Another issue is the order of world generation. Currently, WorldBuilder places each SolarSystemGenerator before calling the build method of each system. This means that the radius of the System has to be determined before build() is called. Therefore, the value of how many planets the SolarSystemGenerator will create needs to be known before any methods from SolarSystemGeneratorImpl can be called. Therefore, the only way for SolarSystemGeneratorImplementations to set the number of planets before their build() method is called is to pass it into the super() constructor. That way it can be taken into account when the superclass's constructor builds the system radius.

It might seem like it would be best to create the SystemRadius during the build() phase of SolarSystemGenerator, however that is problematic because it would mean the WorldBuilder would have to position the System after the build method of SolarSystemGenerator. This would position Mazes wrong, as it would not be possible to place them relative to the SolarSystem position. The WorldBuilder could place the Mazes, but then it would need references to each MazeGeneratorImpl from the SolarSystemGenerators. Also, since SolarSystemGenerators have mazes associated to them in this design, it seems it would be best for them to handle the Maze placement.

lgtm-com · 2021-06-23T15:09:54Z

This pull request introduces 1 alert when merging 5001c5e into 9bfdca7 - view on LGTM.com

new alerts:

1 for Constant loop condition

lgtm-com · 2021-06-23T15:25:25Z

This pull request introduces 1 alert when merging fa5bad0 into 9bfdca7 - view on LGTM.com

new alerts:

1 for Constant loop condition

IsaacLic

If I'm a modder and I want to change one element, how much will I have to re-write the same code, but with a small tweak? For example, what if I want to make a system with a black hole instead of a sun - will I have to rewrite the whole SolarSystemGenerator to change the radius calculation?

IsaacLic · 2021-06-24T14:57:14Z

engine/src/main/java/org/destinationsol/world/generators/FeatureGenerator.java

+        this.radius = radius;
+    }
+
+    public float getRadius() {


I think for this field, it's important to have clear documentation about what this field should represent. The way we discussed it, radius corresponds to the distance from the center to the farthest element in the system. A modder designing a new module might not realize that, though. Imagine someone building a system with only asteroids and no planets, sun, etc - they might think that the radius is zero, which will cause their asteroids to be placed inside another system.

It might be worth having a further discussion about documentation for interfaces and abstract classes. In my opinion, they should have documentation on either the variables or the getters/setters, so that people who want to extend it know what it is and how it works.

IsaacLic · 2021-06-24T15:01:44Z

engine/src/main/java/org/destinationsol/world/WorldBuilder.java

    /**
     * This method initializes the SolarSystemGenerators. How many generators are initialized depends on the number
     * of SolarSystems the world is set to have. When there are multiple types of SolarSystemGenerators available, this
     * method chooses randomly from the list of all generators to decide which to create.
     *
+     * A Class variable is used in this method to allow new instances to be made of each type of available SolarSystemGenerator


I don't think this comment is necessary, but it'd be worth asking @NicholasBatesNZ or @Cervator.

IsaacLic · 2021-06-24T15:06:53Z

engine/src/main/java/org/destinationsol/world/WorldBuilder.java

+     */
+    public void placeSystems() {
+        for (SolarSystemGenerator generator : activeSolarSystemGenerators) {
+            Vector2 position = getSolarSystemPosition(activeSolarSystemGenerators, generator.getRadius());


I think "get" is a bit misleading here - you're calculating it, not retrieving an existing value

IsaacLic · 2021-06-24T18:08:27Z

engine/src/main/java/org/destinationsol/world/WorldBuilder.java

-        initializeRandomSolarSystemGenerators();
+    /**
+     * This method iterates through the loop of SolarSystemGenerators that have been initialized and assigns each of
+     * them a position in the world


IsaacLic · 2021-06-24T18:12:10Z

engine/src/main/java/org/destinationsol/world/WorldBuilder.java

+    }
+
+    /**
+     * This method runs a loop which tests 20 random angles at increasing radii starting from the center of the world


To clarify: it's 20 angles at a given radius length, right? And then after those 20, it increases again?

Yep! This is the game's original logic

Can you clarify that in the documentation?

IsaacLic · 2021-06-25T17:42:22Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

+                solarSystemRadius += groundHeight;
+                solarSystemRadius += Const.ATM_HEIGHT;
+            } else {
+                //add the total height a belt takes up in the SolarSystem (groundHeight will already be negative)


Why is it negative?

IsaacLic · 2021-06-25T17:43:02Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

+                solarSystemRadius -= groundHeight;
+            }
+            //prevents planets from touching in their orbits
+            solarSystemRadius += Const.PLANET_GAP;


Shouldn't this be times the number of planets minus one?

IsaacLic · 2021-06-25T17:43:38Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

+    }
+
+    /**
+     * This places mazes within the outer edge of the solar system. It check to make sure they are places at least 15


"checks", "placed"

IsaacLic · 2021-06-25T17:44:11Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

+
+    /**
+     * This places mazes within the outer edge of the solar system. It check to make sure they are places at least 15
+     * degrees apart so they do not overlap. Currently, it only works properly for two maze SolarSystem (this is the


"two-maze SolarSystems" ?

IsaacLic · 2021-06-25T17:45:17Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

+     * game default)
+     * TODO: refactor to allow for more mazes
+     */
+    void placeMazes() {


Is this supposed to be package-level?

… produces its own radius

IsaacLic

I have two main thoughts:

I don't think that any code should specifically address the concept of multiple suns - see my comments below.
If there's a particular order for how things need to get invoked, make sure that it always happens that way (again, see my comments below).

This is very exciting progress!

IsaacLic · 2021-07-02T13:50:25Z

engine/src/main/java/org/destinationsol/world/WorldBuilder.java

@@ -51,11 +58,10 @@ public WorldBuilder(Context context, int numSystems) {
     * of SolarSystemGenerators.
     */
    private void populateSolarSystemGeneratorList() {
-
        for (Class generator : context.get(ModuleManager.class).getEnvironment().getSubtypesOf(SolarSystemGenerator.class)) {
            try {
                SolarSystemGenerator solarSystemGenerator = (SolarSystemGenerator) generator.newInstance();


If you'll be using the Class to make a new instance, why not store the Class, rather than an instance that isn't getting used?

IsaacLic · 2021-07-02T13:57:11Z

engine/src/main/java/org/destinationsol/world/WorldBuilder.java

+        for (SolarSystemGenerator generator : activeSolarSystemGenerators) {
+            Vector2 position = calculateSolarSystemPosition(activeSolarSystemGenerators, generator.getRadius());
+            generator.setPosition(position);
+            //Printout of generator position for for testing (as these positions don't have a representation in the game yet


IsaacLic · 2021-07-02T13:57:41Z

engine/src/main/java/org/destinationsol/world/WorldBuilder.java

+    }
+
+    /**
+     * This method runs a loop which tests 20 random angles at increasing radii starting from the center of the world


Can you clarify that in the documentation?

IsaacLic · 2021-07-02T13:59:18Z

engine/src/main/java/org/destinationsol/world/WorldBuilder.java

+     * This method iterates through the loop of SolarSystemGenerators that have been initialized and assigns each of
+     * them a position in the world.
+     */
+    public void positionSolarSystems() {


Why is this public? Is this going to be called by other classes?

IsaacLic · 2021-07-02T14:05:06Z

engine/src/main/java/org/destinationsol/world/WorldBuilder.java

+    /**
+     * This method initiates the build process of each SolarSystemGenerator instance.
+     */
+    private void buildSolarSystems() {


If this is happening before the positioning, it should be earlier in the file (for readability)

IsaacLic · 2021-07-02T18:52:09Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

    }

+    /**
+     * This method is used to choose a valid position to insert a belt into. It chooses a position that is between two planets
+     * (not on the edge of the system and not previously used


IsaacLic · 2021-07-02T18:55:22Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

+                float distanceFromSun = featureGenerator.getPosition().dst(this.getPosition());
+                distanceFromSun += Const.PLANET_GAP;
+                distanceFromSun += generator.getRadius();
+                distanceFromSun += generator.getRadius();


Can you add a getDiameter function to FeatureGenerator? While it's not strictly necessary, it'd be nicer to read ;)

IsaacLic · 2021-07-02T19:05:36Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGeneratorImpl.java

+        setPlanetCount(5);
+        setPossibleBeltCount(1);
+        setMazeCount(2);
+        setSunCount(1);


These four lines seem to me like they should really be one method with four parameters, possibly in the abstract class's constructor

IsaacLic · 2021-07-02T19:06:03Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGeneratorImpl.java

+        initializeRandomSunGenerators();
+        initializeRandomPlanetGenerators();
+        initializeRandomMazeGenerators();
+        initializeRandomBeltGenerators(.8f);


These do not seem like they require a specific order, even though they do

These actually do not have a specific order. Each one just get random Planet, Maze, Belt, or Sun types and adds instances of them to the activeFeatureGenerators list

IsaacLic · 2021-07-02T19:08:01Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGeneratorImpl.java

+        calculateMazePositions();
+        calculatePlanetPositions();
+        calculateBeltPositions();
+


Is there a way that this could be partially or fully moved into the abstract class? Modders will have to copy-paste several lines of code for the basic build process to happen

…tor names, refactor configs

IsaacLic

Here's part one of my review - stopping for tonight

IsaacLic · 2021-07-07T19:50:13Z

engine/src/main/java/org/destinationsol/game/planet/BeltConfig.java

+public class BeltConfig {
+
+    public final String name;
+    public final ArrayList<ShipConfig> tempEnemies;


What are these?

IsaacLic · 2021-07-07T19:50:49Z

engine/src/main/java/org/destinationsol/game/planet/BeltConfig.java

+    public final String name;
+    public final ArrayList<ShipConfig> tempEnemies;
+    public final SpaceEnvConfig envConfig;
+    public final ArrayList<ShipConfig> constEnemies;


What are these?

IsaacLic · 2021-07-07T19:51:07Z

engine/src/main/java/org/destinationsol/game/planet/BeltConfig.java

+    public final ArrayList<ShipConfig> tempEnemies;
+    public final SpaceEnvConfig envConfig;
+    public final ArrayList<ShipConfig> constEnemies;
+    public final ArrayList<ShipConfig> constAllies;


What are these?

IsaacLic · 2021-07-07T19:54:08Z

engine/src/main/java/org/destinationsol/game/planet/BeltConfig.java

+    public final ArrayList<ShipConfig> constEnemies;
+    public final ArrayList<ShipConfig> constAllies;
+    public final TradeConfig tradeConfig;
+    public final ArrayList<ShipConfig> innerTempEnemies;


What are these? I'm guessing these fields were copy-pasted from the old code. Can you figure out what they represent and name them accordingly, so that others don't have to rummage through the rest of the codebase to figure out what they are? ;)

IsaacLic · 2021-07-07T19:54:48Z

engine/src/main/java/org/destinationsol/game/planet/BeltConfig.java

+    public final ArrayList<ShipConfig> constAllies;
+    public final TradeConfig tradeConfig;
+    public final ArrayList<ShipConfig> innerTempEnemies;
+    public final boolean hard;


Maybe "isHard" might be a better name? "hard" does not sound like specifically a boolean

Unfortunately it will be hard to change the name, as it needs to be named the same as the key in the JSON will be named

IsaacLic · 2021-07-08T05:08:08Z

engine/src/main/java/org/destinationsol/game/planet/BeltConfigManager.java

+            configsToLoad.put(name, beltConfig);
+        }
+
+        Set<ResourceUrn> configUrnList = Assets.getAssetHelper().listAssets(Json.class, "asteroidBeltsConfig", new Name("engine"));


See above about generification

IsaacLic · 2021-07-08T05:08:17Z

engine/src/main/java/org/destinationsol/game/planet/BeltConfigManager.java

+        Set<ResourceUrn> configUrnList = Assets.getAssetHelper().listAssets(Json.class, "asteroidBeltsConfig", new Name("engine"));
+
+        for (ResourceUrn configUrn : configUrnList) {
+            rootNode = Validator.getValidatedJSON(configUrn.toString(), "engine:schemaSystemsConfig");


IsaacLic · 2021-07-08T05:08:47Z

engine/src/main/java/org/destinationsol/game/planet/BeltConfigManager.java

+
+                BeltConfig config = configsToLoad.get(name);
+
+                // TODO : Maybe add sanity checks for config?


What do you mean?

IsaacLic · 2021-07-08T05:09:26Z

engine/src/main/java/org/destinationsol/game/planet/BeltConfigManager.java

+                // TODO : Maybe add sanity checks for config?
+
+                config.tempEnemies.addAll(ShipConfig.loadList(node.has("temporaryEnemies") ? node.getJSONArray("temporaryEnemies") : null, hullConfigs, itemManager));
+                config.innerTempEnemies.addAll(ShipConfig.loadList(node.has("innerTemporaryEnemies") ? node.getJSONArray("innerTemporaryEnemies") : null, hullConfigs, itemManager));


What do these do?

IsaacLic · 2021-07-08T05:34:39Z

engine/src/main/java/org/destinationsol/game/planet/SolarSystemConfig.java

+    public final ArrayList<ShipConfig> innerTempEnemies;
+    public final boolean hard;
+
+    public SolarSystemConfig(String name, ArrayList<ShipConfig> tempEnemies, SpaceEnvConfig envConfig,


I wonder if the Builder pattern might be better here, to avoid having a bunch of parameters listed like this

@IsaacLic Turns out most of the parameters are pretty useless, as the are only used to pass in empty arrays or objects, and then those are set from JSON data by the load() method. I'm changing it so that those empty objects are initialized in the constructor instead of being passed in

IsaacLic

Mostly minor comments

IsaacLic · 2021-07-08T05:38:17Z

engine/src/main/java/org/destinationsol/world/WorldBuilder.java

-    //These ArrayLists hold instances of any class which extends SolarSystemGenerator or FeatureGenerator, respectively
-    private ArrayList<SolarSystemGenerator> solarSystemGenerators = new ArrayList<>();
-    private ArrayList<FeatureGenerator> featureGenerators = new ArrayList<>();
+    //These ArrayLists hold an instance of any class which extends SolarSystemGenerator or FeatureGenerator, respectively


Technically, I think it's not an instance if it's the actual Class

IsaacLic · 2021-07-09T19:04:54Z

engine/src/main/java/org/destinationsol/game/planet/SolarSystemConfigManager.java

+    }
+
+    private void load(HullConfigManager hullConfigs, boolean b, ItemManager itemManager) {
+        JSONObject rootNode = Validator.getValidatedJSON("engine:systemsConfig", "engine:schemaSystemsConfig");


See BeltConfigManager about my JSON comments

IsaacLic · 2021-07-09T19:06:53Z

engine/src/main/java/org/destinationsol/game/planet/SolarSystemConfigManager.java

+            configsToLoad.put(name, solarSystemConfig);
+        }
+
+        Set<ResourceUrn> configUrnList = Assets.getAssetHelper().listAssets(Json.class, "systemsConfig", new Name("engine"));


This should be made module-friendly

IsaacLic · 2021-07-09T19:25:26Z

engine/src/main/java/org/destinationsol/world/Orbital.java

+ * This class represents one 'ring' around a SolarSystem's center. It is used to keep track of what Features a SolarSystemGenerator
+ * should generate. It keeps track of where those Features will be placed, and whether or not a Feature has been chosen
+ * for a specific orbital. Each orbital has a width, which is the distance from the inner edge of the orbital to the
+ * outer edge.


Excellent javadoc

IsaacLic · 2021-07-09T19:27:41Z

engine/src/main/java/org/destinationsol/world/Orbital.java

+public class Orbital {
+    int positionInSolarSystem;
+    float width;
+    float startingDistanceFromSystemCenter;


What's the difference between this and positionInSolarSystem?

@IsaacLic positionInSolarSystem represents the cardinal order of this orbital. Like the orbital closes to the sun is orbital 0, then orbital 1, etc. I'll come up with a better name

IsaacLic · 2021-07-09T19:49:09Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

-                distanceFromSolarSystemCenter += featureGenerator.getRadius();
-                ((BeltGenerator) featureGenerator).setDistanceFromCenter(distanceFromSolarSystemCenter);
+                //remove the planet that was going to be placed in this orbital
+                featureGeneratorsToRemove.add(solarSystemOrbitals.get(orbitInsertionPosition).getFeatureGenerator());


I'm not clear on what this does

IsaacLic · 2021-07-09T19:50:16Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

     * It will only choose FeatureGenerators which are subclasses of {@link SunGenerator}.
-     * It will continue to make new instances until the correct number of Suns is reached
+     * It will make one sun generator instance.


I think this line of comment is likely unnecessary

IsaacLic · 2021-07-09T19:51:57Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

-                    e.printStackTrace();
-                }
+    protected void initializeRandomSunGenerator() {
+        int index = SolRandom.seededRandomInt(featureGeneratorTypes.size());


You do still need a while loop to ensure that the sun actually gets created

IsaacLic · 2021-07-09T19:52:32Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

@@ -204,11 +275,12 @@ protected void initializeRandomPlanetGenerators() {
     * It will continue to make new instances until the correct number of Mazes is reached
     */
    protected void initializeRandomMazeGenerators() {
-        int mazesLeft = getMazeCount();
+        //we will initialize up to 12 mazes to ensure they fit around the SolarSystem


Good thinking

IsaacLic · 2021-07-09T19:53:57Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

     * @param secondAngleToCheck angle to compare it to
-     * @param degrees how many degrees apart to ensure angles are between
+     * @param degrees            how many degrees apart to ensure angles are between


Probably too much space ;)

NicholasBatesNZ

My brain got fried long before I finished this review. Remind me to merge more often...

NicholasBatesNZ · 2021-07-15T01:30:36Z

engine/src/main/java/org/destinationsol/game/SolGame.java

        //World Generation will be initiated from here
        worldBuilder.buildWithRandomSolarSystemGenerators();
+        //this is just temporarily loaded here so that current world-gen implementation works


Use //TODO: comment so that it gets highlighted for future action

NicholasBatesNZ · 2021-07-15T01:38:35Z

engine/src/main/java/org/destinationsol/world/WorldBuilder.java

-            } catch (InstantiationException | IllegalAccessException e) {
-                e.printStackTrace();
-            }
+            solarSystemGeneratorTypes.add(generator);


private ModuleManager moduleManager = context.get(ModuleManager.class); ... solarSystemGeneratorTypes.addAll(moduleManager.getEnvironment().getSubtypesOf(SolarSystemGenerator.class));

NicholasBatesNZ · 2021-07-15T01:40:53Z

engine/src/main/java/org/destinationsol/world/WorldBuilder.java

            }
        }
    }

+    public void buildWithRandomSolarSystemGenerators() {


No javadocs? 😢

NicholasBatesNZ · 2021-07-15T01:43:26Z

engine/src/main/java/org/destinationsol/world/WorldBuilder.java

+                SolarSystemGenerator s = solarSystemGenerator.newInstance();
+                s.setFeatureGeneratorTypes(featureGeneratorTypes);
+                s.setSolarSystemConfigManager(solarSystemConfigManager);
+                s.setSolarSystemNumber(i);
+                generatorArrayList.add(s);


I get that this variable doesn't live very long but please don't get into the habit of single letter names. Something like generator would be better

NicholasBatesNZ · 2021-07-15T01:47:36Z

engine/src/main/java/org/destinationsol/world/WorldBuilder.java

+            Vector2 position = calculateSolarSystemPosition(activeSolarSystemGenerators, generator.getRadius());
+            generator.setPosition(position);
+            //Printout of generator position for testing (as these positions don't have a representation in the game yet)
+            System.out.println(generator + " position: " + generator.getPosition().x + ", " + generator.getPosition().y);


You should be using a logger rather than stdio.

private static final Logger logger = LoggerFactory.getLogger(WorldBuilder.class); ... // any of: logger.info("msg"); logger.debug("msg"); logger.error("msg");

NicholasBatesNZ · 2021-07-15T02:19:19Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

+    private void calculatePlanetPositions() {
+        int orbitalPosition = 0;
+        for (FeatureGenerator featureGenerator : activeFeatureGenerators) {
+            Vector2 result = new Vector2();


vector pool

NicholasBatesNZ · 2021-07-15T02:19:38Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

+                result.add(position);
+                generator.setPosition(result);
+
+                System.out.println(generator + " distance from center: " + generator.distanceFromSolarSystemCenter);


NicholasBatesNZ · 2021-07-15T02:20:02Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

+                is placed, a planet is removed and a maze set in its place */
+                featureGeneratorsToRemove.add(solarSystemOrbitals.get(orbitInsertionPosition).getFeatureGenerator());
+                solarSystemOrbitals.get(orbitInsertionPosition).setFeatureGenerator(featureGenerator);
+                System.out.println("Distance for belt: " + distanceFromSolarSystemCenter);


NicholasBatesNZ · 2021-07-15T02:23:25Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

+    }
+
+    /**
+     * This method checks if two angles are within a certain number of degrees of each other or not


If it only checks two angles then why is the first argument a list?

NicholasBatesNZ · 2021-07-15T02:23:58Z

engine/src/main/java/org/destinationsol/world/generators/SolarSystemGenerator.java

+        return radius;
+    }
+
+    public void setPositioned(boolean p) {


single letter var name

IsaiahBlanks added 2 commits June 23, 2021 09:40

Initial SolarSystemGenerator designing

9297ad4

Fixed commit issues which brought in old changes

5001c5e

IsaiahBlanks added 2 commits June 23, 2021 11:15

Fixed typos

e78fae3

WorldBuilder javadoc

fa5bad0

IsaacLic reviewed Jun 25, 2021

View reviewed changes

IsaiahBlanks added 2 commits June 30, 2021 15:40

Finished calculating position of Features, Refactored so each feature…

507d5f7

… produces its own radius

Fixed failing WorldBuilder test

9e4b7e1

IsaacLic reviewed Jul 2, 2021

View reviewed changes

Positions systems before building, SolarSystem orbital options, refac…

8f278db

…tor names, refactor configs

IsaacLic reviewed Jul 8, 2021

View reviewed changes

IsaacLic reviewed Jul 9, 2021

View reviewed changes

Tests working with configs,

eeb45d7

IsaiahBlanks marked this pull request as ready for review July 13, 2021 00:40

Fixed bad import causing error

da88560

NicholasBatesNZ requested changes Jul 15, 2021

View reviewed changes

Improved Javadoc, Vector Pool, logger, naming, imports

6d70657

NicholasBatesNZ merged commit 6d70657 into MovingBlocks:gsoc2021 Jul 18, 2021


		BeltConfig config = configsToLoad.get(name);

		// TODO : Maybe add sanity checks for config?

Initial SolarSystemGenerator design #597

Initial SolarSystemGenerator design #597

Conversation

IsaiahBlanks commented Jun 23, 2021 • edited

Description

Testing

Design Questions

lgtm-com bot commented Jun 23, 2021

lgtm-com bot commented Jun 23, 2021

IsaacLic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsaacLic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsaacLic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsaacLic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NicholasBatesNZ left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsaiahBlanks commented Jun 23, 2021 •

edited