Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maze Generators and Belts Generators #603

Merged
merged 6 commits into from Aug 19, 2021

Conversation

IsaiahBlanks
Copy link
Contributor

Description

This PR adds Belts and Mazes using Generator classes. It brings the GSoC 2021 Destination: Sol project up to have all the features of develop, but now modular! It includes tests for the BeltGenerator and MazeGenerator classes.

Testing

Load up the game, especially with 4 or more Solar Systems. You'll see belts and mazes througout the Systems. There are two types of belts and two types of mazes to see. They should generate properly.

Notes

There is still more to be done on the GSoC 2021 project, including writing a tutorial for doing mods and a few other things.

@IsaiahBlanks IsaiahBlanks changed the base branch from develop to gsoc2021 August 4, 2021 02:51
Copy link
Member

@Cervator Cervator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick initial pass, seems okay, but this is a light approval 😁 Would be nice to get a quick pass from one of @IsaacLic @NicholasBatesNZ @Adrijaned or somebody else. I figure ultimately the architecture / class tree could be improved a bit better, but I don't think we need to accomplish that all in one go - iterate iterate iterate.

Tests out too, that was one dense belt I flew through, I like it!

If nobody else gets a chance to review this deeper we can probably merge it soon'ish even without further approval :-)

Nice work! Hooray nearly complete refactoring!

Copy link
Contributor

@IsaacLic IsaacLic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent! I didn't quite finish reviewing - I have four files left to look at - but this looks amazing :)

Copy link
Contributor

@IsaacLic IsaacLic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent! One small comment about the casting thing, but otherwise looks great :)

@IsaacLic IsaacLic merged commit f0bce9c into MovingBlocks:gsoc2021 Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants