Maze Layout System #604
Merged
Maze Layout System #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacLic
reviewed
Aug 24, 2021
Contributor
IsaacLic
left a comment
IsaacLic
left a comment
There was a problem hiding this comment.
Looks good to me! If someone can test it and confirm it works well, I'll merge it
engine/src/main/java/org/destinationsol/game/maze/MazeConfigManager.java
Show resolved
Hide resolved
engine/src/main/java/org/destinationsol/game/maze/MazeLayoutBuilder.java
Show resolved
Hide resolved
engine/src/main/java/org/destinationsol/world/generators/SmallMazeGenerator.java
Show resolved
Hide resolved
Member
Fixed issues with tests failing
Member
|
I've tested this locally although my Android setup might be broken - I am pretty sure I saw a new maze and everything seemed to work. Even with a few outstanding comments I'm going to go ahead and merge this and make a follow-up issue :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a system for users to add their own custom maze layouts. These are represented in JSON by 2D arrays, and in the game as areas where mazes tiles do or do not generate. Also in this PR, WorldBuilder is renamed to GalaxyBuilder.
Testing
Fly around until you find a smaller Maze. If you are lucky, it will by a SpiralMaze. You'll be able to tell by the spiral shape the maze forms (it is a bit too big to see at once, fly around the maze a bit to tell).
Outstanding Work
This one involves loading in JSON so I wasn't sure how to write unit tests for it, but that still need to be done.