Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using the zip FSP in SaveTransaction #2354

Closed
msteiger opened this issue Jun 13, 2016 · 1 comment
Closed

Avoid using the zip FSP in SaveTransaction #2354

msteiger opened this issue Jun 13, 2016 · 1 comment
Labels
Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc.

Comments

@msteiger
Copy link
Member

msteiger commented Jun 13, 2016 •
edited by Cervator

The SaveTransaction class uses the forbidden (eclipse speak) class com.sun.nio.zipfs.ZipFileSystemProvider.

It should use FileSystems.newFileSystem() instead.

Pinging @flo for potential interest.
@rzats rzats added the Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. label Jun 13, 2016
@Cervator
Copy link
Member

Interesting, I thought we had evicted everything com.sun long ago. I see we have a couple win32 usages too but maybe they have to work differently for OS specific stuff.

Reminds me of #1637

theobisproject added a commit to theobisproject/Terasology that referenced this issue Apr 27, 2017
@theobisproject
Replace JDK internal ZipFileSystemProvider with FileSystems public API
219dd2d 
Fixes MovingBlocks#2354
theobisproject added a commit to theobisproject/Terasology that referenced this issue Apr 27, 2017
@theobisproject
Replace JDK internal ZipFileSystemProvider with FileSystems public API
95befa5 
Fixes MovingBlocks#2354
@theobisproject theobisproject mentioned this issue Apr 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Cervator @msteiger @rzats