New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha 7 release prep and QA #2766

Closed
Cervator opened this Issue Jan 29, 2017 · 8 comments

Comments

Projects
None yet
4 participants
@Cervator
Member

Cervator commented Jan 29, 2017

We should be able to do an Alpha 7 release soon including all the goodies from GCI.

This issue is meant as a focal point for release preparation efforts.

Multiplayer Testing

The Official Event Host has been updated with Omega 681 as the first potential release candidate and is running NeoTTA. Known issues (help find more!):

  • Upgrading a workstation causes a client crash. Closing the workstation UI makes the "Update" button go away so clearly something is missing
  • Progress bar missing when you craft something with duration like with the portable forging station (the item does finish crafting and appear if you wait)
  • Amusingly you can place a basket inside itself - which is probably more of a general issue rather than specific to NeoTTA multiplayer, but still funny
  • Out of memory issues can occur easily, especially via in-game help, probably related to odd-sized images in Cooking, SimpleFarming, Equipment, etc? Need to either look for more images to resize or try to figure out what causes the inefficiency about those kinds of images.
  • ... help us find more!

Also should we include the overhaul of effects? @xrtariq2594? Seems to involve:

Some of those are quite a few commits behind their matching master branch though.

A few more issues from earlier are listed at http://forum.terasology.org/threads/google-code-in-2016-done.1634/#post-14394

Other Issues

  • StructureTemplates has been updated by @flo with some great new tooling but this means updates are needed to get away from an outdated "front" config in existing prefabs. See its forum thread for details. I did some version bumps but when I ran with MedievalCities the game went boom (I didn't try to adjust the templates directly yet).
  • Updates needed in MedievalCities - @skaldarnar?
  • Updates needed in TutorialDynamicCities - @CptCrispyCrunchy?
  • Updates needed in RomanCities- @SufurElite?
  • Updates needed in ModernCities - @mdj117?
  • Updates needed in Mineshafts - @MaxBorsch?
  • Torchlight when held seems to be broken and the goodie chests from Core likewise - #2788, fixed via revert in #2806 of #2672
  • Some held items appear fully lit regardless of environment light level - #2804
  • Distant name tag display: either hide a tag if the other player isn't visible, or make only nearby tags show?

Test plans

We have these now! Any volunteers to help execute them as part of testing?

  • Potions
  • .. need somebody to add more for what we have covered. @nihal111?

@Cervator Cervator added this to the Alpha 7 milestone Jan 29, 2017

@Cervator

This comment has been minimized.

Show comment
Hide comment
@Cervator

Cervator Feb 8, 2017

Member

Might also be good to work on some release notes on what's new, especially outside the engine. Although with everything from GCI including ... yikes that'd be a big list. I've tried to keep track in Trello on occasion but it might be worth tracking in a release prep issue like this one

  • Terasology/FunnyBlocks#8 - new "trap" type block that breaks after being stepped on
  • Terasology/FunnyBlocks#9 - new Portal style portal blocks (place orange and blue portal blocks, activate one of each, get 2-way teleport link between them)
Member

Cervator commented Feb 8, 2017

Might also be good to work on some release notes on what's new, especially outside the engine. Although with everything from GCI including ... yikes that'd be a big list. I've tried to keep track in Trello on occasion but it might be worth tracking in a release prep issue like this one

  • Terasology/FunnyBlocks#8 - new "trap" type block that breaks after being stepped on
  • Terasology/FunnyBlocks#9 - new Portal style portal blocks (place orange and blue portal blocks, activate one of each, get 2-way teleport link between them)
@nihal111

This comment has been minimized.

Show comment
Hide comment
@nihal111

nihal111 Mar 3, 2017

Member

I had created the doc containing everything that was done in GCI apart from PRs and issues that can easily be tracked. Here it is 😄

Member

nihal111 commented Mar 3, 2017

I had created the doc containing everything that was done in GCI apart from PRs and issues that can easily be tracked. Here it is 😄

@xrtariq2594

This comment has been minimized.

Show comment
Hide comment
@xrtariq2594

xrtariq2594 Mar 4, 2017

Contributor

Upgrading a workstation causes a client crash. Closing the workstation UI makes the "Update" button go away so clearly something is missing

Yep, that's a known issue. I tried resolving that in some personal repos, but no luck. The files in question involved are: CraftingStationWindow.java, CraftingStationWindowSystem.java, and CraftingStationUpgraded.java.

What happens on the client end is that once the event is sent to the server to upgrade the workstation, the old NUI workstation window is destroyed. On the server side, it's alright as it's auto-closed and updated correctly upon the event. On the client side, it now refers to a non-existent or NULL NUI window, and thus crashes.

I tried doing the following in the CraftingStationWindowSystem:

@ReceiveEvent
public void onCraftingStationUpgraded(CraftingStationUpgraded event, EntityRef entity) {

But that method never receives the event, and thus, cannot update the window reference. I tried making CraftingStationUpgraded a BroadcastEvent, but that didn't work either the last time.

Contributor

xrtariq2594 commented Mar 4, 2017

Upgrading a workstation causes a client crash. Closing the workstation UI makes the "Update" button go away so clearly something is missing

Yep, that's a known issue. I tried resolving that in some personal repos, but no luck. The files in question involved are: CraftingStationWindow.java, CraftingStationWindowSystem.java, and CraftingStationUpgraded.java.

What happens on the client end is that once the event is sent to the server to upgrade the workstation, the old NUI workstation window is destroyed. On the server side, it's alright as it's auto-closed and updated correctly upon the event. On the client side, it now refers to a non-existent or NULL NUI window, and thus crashes.

I tried doing the following in the CraftingStationWindowSystem:

@ReceiveEvent
public void onCraftingStationUpgraded(CraftingStationUpgraded event, EntityRef entity) {

But that method never receives the event, and thus, cannot update the window reference. I tried making CraftingStationUpgraded a BroadcastEvent, but that didn't work either the last time.

@xrtariq2594

This comment has been minimized.

Show comment
Hide comment
@xrtariq2594

xrtariq2594 Mar 4, 2017

Contributor

Also should we include the overhaul of effects? @xrtariq2594? Seems to involve:

Sure! Go right ahead. Though, please open up a separate server for that, just in case something goes awry.

Contributor

xrtariq2594 commented Mar 4, 2017

Also should we include the overhaul of effects? @xrtariq2594? Seems to involve:

Sure! Go right ahead. Though, please open up a separate server for that, just in case something goes awry.

@Cervator

This comment has been minimized.

Show comment
Hide comment
@Cervator

Cervator Mar 5, 2017

Member

Another useful play test today and thanks to @nihal111 we got the one outstanding blocker fixed!

Talked to @xrtariq2594 about NeoTTA and will probably hold on just a bit with merging the new effects system if I'm able to build the Alpha 7 release tomorrow. Omega 681 is on the event server now as a potential release candidate.

Talked to @emanuele3d about some best practices for artwork as the apple tree leaf blocks look a little odd now as they have transparent bits yet only the outermost textures render (all internal ones occlude, although the backside still renders due to the blocks set to double sided)

Suggestion from there we should probably add to a sort of best practices for artwork and outstanding work:

  • Avoid transparent pixels on textures meant to be used for tree canopies (OK for single block bushes)
  • Add bite-sized issue to edit existing tree canopy type textures so that they don't have any transparency plus edit the .block files so that their doubleSided/translucent attributes are set to false (or removed if that's the default)
  • We still need to clean up the images in Cooking some more

I also encountered a weird crash I haven't hit before, but I wonder if it might be too rare to worry about. A music piece ended, and boom:

17:00:58.290 [main] INFO  o.t.logic.console.ConsoleImpl - [CONSOLE] Message sent.
17:01:08.743 [main] INFO  o.t.logic.console.ConsoleImpl - [CHAT] Manu3d: =)
17:01:20.278 [main] INFO  o.t.logic.console.ConsoleImpl - [CHAT] Manu3d: What frame rate are you getting here?
17:01:31.051 [main] WARN  o.t.engine.internal.TimeBase - Delta too great (1177), capping to 1000
17:01:31.057 [main] ERROR o.terasology.engine.TerasologyEngine - Uncaught exception, attempting clean game shutdown
org.terasology.audio.openAL.OpenALException: OpenAL Error (40963) at Buffer unqueue - Invalid Value
	at org.terasology.audio.openAL.streamingSound.OpenALStreamingSoundSource.update(OpenALStreamingSoundSource.java:80)
	at org.terasology.audio.openAL.BaseSoundPool.lambda$update$361(BaseSoundPool.java:114)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source)
	at java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
	at java.util.HashMap$KeySpliterator.forEachRemaining(Unknown Source)
	at java.util.stream.AbstractPipeline.copyInto(Unknown Source)
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
	at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
	at java.util.stream.AbstractPipeline.evaluate(Unknown Source)
	at java.util.stream.ReferencePipeline.forEach(Unknown Source)
	at org.terasology.audio.openAL.BaseSoundPool.update(BaseSoundPool.java:114)
	at org.terasology.audio.openAL.OpenALManager.update(OpenALManager.java:263)
	at org.terasology.engine.subsystem.lwjgl.LwjglAudio.postUpdate(LwjglAudio.java:64)
	at org.terasology.engine.TerasologyEngine.mainLoop(TerasologyEngine.java:422)
	at org.terasology.engine.TerasologyEngine.run(TerasologyEngine.java:368)
	at org.terasology.engine.Terasology.main(Terasology.java:152)
17:01:31.057 [main] INFO  o.terasology.engine.TerasologyEngine - Shutting down Terasology...
17:01:31.074 [main] INFO  o.t.n.internal.NetworkSystemImpl - Network shutdown
17:01:31.226 [main] WARN  o.t.rendering.nui.skin.UISkinFormat - Failed to resolve UIWidget class UIInputBindButton, skipping style information

Unsure if I should submit that as a separate issue, especially if it came from OpenAL

Member

Cervator commented Mar 5, 2017

Another useful play test today and thanks to @nihal111 we got the one outstanding blocker fixed!

Talked to @xrtariq2594 about NeoTTA and will probably hold on just a bit with merging the new effects system if I'm able to build the Alpha 7 release tomorrow. Omega 681 is on the event server now as a potential release candidate.

Talked to @emanuele3d about some best practices for artwork as the apple tree leaf blocks look a little odd now as they have transparent bits yet only the outermost textures render (all internal ones occlude, although the backside still renders due to the blocks set to double sided)

Suggestion from there we should probably add to a sort of best practices for artwork and outstanding work:

  • Avoid transparent pixels on textures meant to be used for tree canopies (OK for single block bushes)
  • Add bite-sized issue to edit existing tree canopy type textures so that they don't have any transparency plus edit the .block files so that their doubleSided/translucent attributes are set to false (or removed if that's the default)
  • We still need to clean up the images in Cooking some more

I also encountered a weird crash I haven't hit before, but I wonder if it might be too rare to worry about. A music piece ended, and boom:

17:00:58.290 [main] INFO  o.t.logic.console.ConsoleImpl - [CONSOLE] Message sent.
17:01:08.743 [main] INFO  o.t.logic.console.ConsoleImpl - [CHAT] Manu3d: =)
17:01:20.278 [main] INFO  o.t.logic.console.ConsoleImpl - [CHAT] Manu3d: What frame rate are you getting here?
17:01:31.051 [main] WARN  o.t.engine.internal.TimeBase - Delta too great (1177), capping to 1000
17:01:31.057 [main] ERROR o.terasology.engine.TerasologyEngine - Uncaught exception, attempting clean game shutdown
org.terasology.audio.openAL.OpenALException: OpenAL Error (40963) at Buffer unqueue - Invalid Value
	at org.terasology.audio.openAL.streamingSound.OpenALStreamingSoundSource.update(OpenALStreamingSoundSource.java:80)
	at org.terasology.audio.openAL.BaseSoundPool.lambda$update$361(BaseSoundPool.java:114)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source)
	at java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
	at java.util.HashMap$KeySpliterator.forEachRemaining(Unknown Source)
	at java.util.stream.AbstractPipeline.copyInto(Unknown Source)
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
	at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
	at java.util.stream.AbstractPipeline.evaluate(Unknown Source)
	at java.util.stream.ReferencePipeline.forEach(Unknown Source)
	at org.terasology.audio.openAL.BaseSoundPool.update(BaseSoundPool.java:114)
	at org.terasology.audio.openAL.OpenALManager.update(OpenALManager.java:263)
	at org.terasology.engine.subsystem.lwjgl.LwjglAudio.postUpdate(LwjglAudio.java:64)
	at org.terasology.engine.TerasologyEngine.mainLoop(TerasologyEngine.java:422)
	at org.terasology.engine.TerasologyEngine.run(TerasologyEngine.java:368)
	at org.terasology.engine.Terasology.main(Terasology.java:152)
17:01:31.057 [main] INFO  o.terasology.engine.TerasologyEngine - Shutting down Terasology...
17:01:31.074 [main] INFO  o.t.n.internal.NetworkSystemImpl - Network shutdown
17:01:31.226 [main] WARN  o.t.rendering.nui.skin.UISkinFormat - Failed to resolve UIWidget class UIInputBindButton, skipping style information

Unsure if I should submit that as a separate issue, especially if it came from OpenAL

@skaldarnar

This comment has been minimized.

Show comment
Hide comment
@skaldarnar

skaldarnar Apr 9, 2017

Member

@Cervator Alpha 7 is released, can this be closed or should it stay active for outstanding issues?

Member

skaldarnar commented Apr 9, 2017

@Cervator Alpha 7 is released, can this be closed or should it stay active for outstanding issues?

@Cervator

This comment has been minimized.

Show comment
Hide comment
@Cervator

Cervator May 8, 2017

Member

Sorry for the belated reply @skaldarnar :D

I wanted to close this out by pushing forward any remaining issues to somewhere appropriate. I just submitted a similar issue for Alpha 8. We probably just need to create some follow-up issues here and there, much like we should after doing a play test and reviewing an associated project board.

Won't have time tonight but am beginning to like the extra bit of "glue" we can get with these issues and play tests. Easier to connect the dots and spot the repeat offender issues we hit :)

Member

Cervator commented May 8, 2017

Sorry for the belated reply @skaldarnar :D

I wanted to close this out by pushing forward any remaining issues to somewhere appropriate. I just submitted a similar issue for Alpha 8. We probably just need to create some follow-up issues here and there, much like we should after doing a play test and reviewing an associated project board.

Won't have time tonight but am beginning to like the extra bit of "glue" we can get with these issues and play tests. Easier to connect the dots and spot the repeat offender issues we hit :)

@Cervator

This comment has been minimized.

Show comment
Hide comment
@Cervator

Cervator Sep 2, 2017

Member

Closing this at long last as part of Alpha 8 release prep, pushing forward a few open items to newer issues :-)

Member

Cervator commented Sep 2, 2017

Closing this at long last as part of Alpha 8 release prep, pushing forward a few open items to newer issues :-)

@Cervator Cervator closed this Sep 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment