New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fog, volumetric fog and particle effect limit options #2211

Merged
merged 2 commits into from Mar 8, 2016

Conversation

Projects
None yet
4 participants
@tdgunes
Member

tdgunes commented Mar 7, 2016

Contains

Yet another partial fix for #1144

How to test

Additions can be seen in video settings menu.

For testing, particle effect limit: picking block from ground generates multiple particles during animation.

For testing: fog: blocks that are far from the player will be foggy or not according to setting. For future, there can be extra options for fog like density, colour, equation (linear, exp or etc.).

For volumetric fog, I couldn't find a proper test case for trying out volumetric fog implementation in "combine" shader. But, my current addition can turn it on or off. It would be great if someone can provide instructions for me to test recent additions.

@GooeyHub

This comment has been minimized.

Show comment
Hide comment
@GooeyHub

GooeyHub Mar 7, 2016

Member

Can one of the admins please verify this patch?

Member

GooeyHub commented Mar 7, 2016

Can one of the admins please verify this patch?

@GooeyHub GooeyHub added the in progress label Mar 7, 2016

@tdgunes tdgunes changed the title from Add fog, volumetric fog and particle effect limit options inside grap… to Add fog, volumetric fog and particle effect limit options Mar 7, 2016

@Cervator

This comment has been minimized.

Show comment
Hide comment
@Cervator

Cervator Mar 7, 2016

Member

add to whitelist

Hey @tdgunes and thanks :-)

On volumetric fog I wonder if it is even enabled at present? I remembered an old video showcasing it nearly three years ago by @begla where he would enable / increase volumetric fog via sliders in TeraEd (an alternatively game facade launching with some extra graphics config)

https://www.youtube.com/watch?v=cXiX5ZJT_-k

I just realized that video is unlisted rather than published, so very few people have ever seen it. Maybe it was implemented but never fully finished up for actual use? That was back around the end of our 3d wizardry heavy period.

@emanuele3d might have a related clue or two

Member

Cervator commented Mar 7, 2016

add to whitelist

Hey @tdgunes and thanks :-)

On volumetric fog I wonder if it is even enabled at present? I remembered an old video showcasing it nearly three years ago by @begla where he would enable / increase volumetric fog via sliders in TeraEd (an alternatively game facade launching with some extra graphics config)

https://www.youtube.com/watch?v=cXiX5ZJT_-k

I just realized that video is unlisted rather than published, so very few people have ever seen it. Maybe it was implemented but never fully finished up for actual use? That was back around the end of our 3d wizardry heavy period.

@emanuele3d might have a related clue or two

@GooeyHub

This comment has been minimized.

Show comment
Hide comment
@GooeyHub

GooeyHub Mar 7, 2016

Member

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/462/
Hooray Jenkins reported success with all tests good!

Member

GooeyHub commented Mar 7, 2016

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/462/
Hooray Jenkins reported success with all tests good!

#endif
#if defined (VOLUMETRIC_FOG)
#ifdef VOLUMETRIC_FOG

This comment has been minimized.

@emanuele3d

emanuele3d Mar 7, 2016

Contributor

I just read about the difference between #ifdef and #if defined. Good idea changing it.

@emanuele3d

emanuele3d Mar 7, 2016

Contributor

I just read about the difference between #ifdef and #if defined. Good idea changing it.

@GooeyHub

This comment has been minimized.

Show comment
Hide comment
@GooeyHub

GooeyHub Mar 8, 2016

Member

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/465/
Hooray Jenkins reported success with all tests good!

Member

GooeyHub commented Mar 8, 2016

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/465/
Hooray Jenkins reported success with all tests good!

@Cervator

This comment has been minimized.

Show comment
Hide comment
@Cervator

Cervator Mar 8, 2016

Member

Hehe, probably best that volumetric fog is off by default :D

terasology-160308174329-1152x720

Otherwise yeah the switches work and that was the plan :-)

Member

Cervator commented Mar 8, 2016

Hehe, probably best that volumetric fog is off by default :D

terasology-160308174329-1152x720

Otherwise yeah the switches work and that was the plan :-)

@Cervator Cervator added this to the v1.0.0 milestone Mar 8, 2016

Cervator added a commit that referenced this pull request Mar 8, 2016

@Cervator Cervator merged commit 8cbf61a into MovingBlocks:develop Mar 8, 2016

1 check passed

default Build finished. 473 tests run, 0 skipped, 0 failed.
Details

@Cervator Cervator changed the title from Add fog, volumetric fog and particle effect limit options to Add fog, volumetric fog and particle effect limit options Mar 8, 2016

@Cervator Cervator removed the in progress label Mar 8, 2016

@skaldarnar skaldarnar referenced this pull request Mar 21, 2016

Closed

Volumetric Fog broken #2246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment