Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Finalize SetWireframe StateChange #2421
As title mentions, finalizes a Wireframe state change for All obvious State Changes implemented
How to test
By checking the log and observing wireframe debug mode.
FYI: Debug mode is toggled by F3 key and wireframe with F9.
An example screenshot when wireframe is enabled:
Eliminations must be seen in the log:
This PR also includes setViewportSizeOf PR. Please just focus on last commit.
added a commit
this pull request
Jul 31, 2016
I have gazed upon the arcane spiderweb of 3d wizardry, and it was good. I now know kung fu.
As noted in the top post this also included #2419 which I guess may or may not have outstanding comments? In any case I would grab latest including the conflict resolution and apply any needed tweaks on top :-)
Hmmm... this merge was a bit of a mess - my fault.
What I could see specifically from this PR was ready for merge, but I hadn't realized that this PR was based on another one that wasn't quite ready to go yet.
@Cervator: how can we avoid this happening again?
@emanuele3d that was what I was getting at on Slack :-) While functionally distinct PRs may ease review if they overlap in code this sort of thing can happen. Not a lot to do about it other than keeping stuff more insulated or closing older PRs as they're superseded by newer ones (or I guess keep them open but with the understanding that they're subordinate to some further along PR)
Git and GitHub doesn't really care what we do about PRs so long as all the right commits end up in the right branch eventually.