New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Minor Refactor in StateChanges #2425

Merged
merged 4 commits into from Aug 3, 2016

Conversation

Projects
None yet
4 participants
@tdgunes
Member

tdgunes commented Jul 31, 2016

Contains

As title mentions, adds some necessary refactors according to given feedback on #2419 for All obvious State Changes implemented

How to test

Check any weirdness on rendering, especially during the startup.

@tdgunes tdgunes changed the title from Refactors in StateChanges to [RFR] A Minor Refactor in StateChanges Jul 31, 2016

@GooeyHub

This comment has been minimized.

Show comment
Hide comment
@GooeyHub

GooeyHub Jul 31, 2016

Member

Hooray Jenkins reported success with all tests good!

Member

GooeyHub commented Jul 31, 2016

Hooray Jenkins reported success with all tests good!

@emanuele3d

This comment has been minimized.

Show comment
Hide comment
@emanuele3d

emanuele3d Jul 31, 2016

Contributor

A few quick issues to deal with and also this PR will be good to go.

Contributor

emanuele3d commented Jul 31, 2016

A few quick issues to deal with and also this PR will be good to go.

@tdgunes tdgunes referenced this pull request Jul 31, 2016

Merged

New StateChanges for DAG #2427

@tdgunes tdgunes changed the title from [RFR] A Minor Refactor in StateChanges to [WIP] A Minor Refactor in StateChanges Jul 31, 2016

@tdgunes tdgunes changed the title from [WIP] A Minor Refactor in StateChanges to [RFR] A Minor Refactor in StateChanges Jul 31, 2016

@GooeyHub

This comment has been minimized.

Show comment
Hide comment
@GooeyHub

GooeyHub Jul 31, 2016

Member

Hooray Jenkins reported success with all tests good!

Member

GooeyHub commented Jul 31, 2016

Hooray Jenkins reported success with all tests good!

@GooeyHub

This comment has been minimized.

Show comment
Hide comment
@GooeyHub

GooeyHub Aug 2, 2016

Member

Uh oh, something went wrong with the build. Need to check on that

Member

GooeyHub commented Aug 2, 2016

Uh oh, something went wrong with the build. Need to check on that

@GooeyHub

This comment has been minimized.

Show comment
Hide comment
@GooeyHub

GooeyHub Aug 2, 2016

Member

Hooray Jenkins reported success with all tests good!

Member

GooeyHub commented Aug 2, 2016

Hooray Jenkins reported success with all tests good!

@emanuele3d

This comment has been minimized.

Show comment
Hide comment
@emanuele3d

emanuele3d Aug 2, 2016

Contributor

Ok, for some reason github didn't notify me that the latest commits have been submitted after my last visit. That's why I got confused and didn't realise that my feedback has been addressed. But addressed it has been and I think this PR can be merged at your convenience @Cervator.

Good job @tdgunes!

Contributor

emanuele3d commented Aug 2, 2016

Ok, for some reason github didn't notify me that the latest commits have been submitted after my last visit. That's why I got confused and didn't realise that my feedback has been addressed. But addressed it has been and I think this PR can be merged at your convenience @Cervator.

Good job @tdgunes!

@Cervator Cervator merged commit bec343b into MovingBlocks:develop Aug 3, 2016

1 check passed

default Build finished.
Details

Cervator added a commit that referenced this pull request Aug 3, 2016

@Cervator Cervator added this to the Alpha 3 milestone Aug 3, 2016

@Cervator Cervator removed the in progress label Aug 3, 2016

@Cervator

This comment has been minimized.

Show comment
Hide comment
@Cervator

Cervator Aug 3, 2016

Member

Merged! :-)

Member

Cervator commented Aug 3, 2016

Merged! :-)

@emanuele3d

This comment has been minimized.

Show comment
Hide comment
@emanuele3d

emanuele3d Aug 3, 2016

Contributor

Thank you @Cervator! Good job @tdgunes!

Contributor

emanuele3d commented Aug 3, 2016

Thank you @Cervator! Good job @tdgunes!

@tdgunes tdgunes changed the title from [RFR] A Minor Refactor in StateChanges to A Minor Refactor in StateChanges Aug 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment