Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
New StateChanges for DAG #2427
@tdgunes: what's happening with this PR? I'd really like to see this one closed before the FBO one proceeds. Furthermore, I suspect we need to make a pause here and assess what's happening with the issue #2418. Perhaps if this PR is completed and all nodes take advantage of the new state changes that issue might get solved automagically. But I wouldn't bet on it.
Tested again and no obvious issues when just varying shadows and such under normal conditions, water reflections on global still look awesome but - I think there may be an issue (at least for me) with lighting, specifically when the player equips a luminous object like a torch.
Last time I tested the "underside" view of the world changed dramatically when I equipped a torch which I wrote off as being an oddity from being under the world, but I just realized it happens when just walking around on the right side of the world and switching to a torch. The sky goes black, water disappears, and some weird skysphere-related pattern becomes visible.
While I have nothing to base this on I suspect this is probably something simple for a 3d wizard (similar effects have happened before). It appears active across all settings I tried, from minimal to ultra, before or after changing settings in-game. But it would be good to know if anybody else sees it :-)
Weird skysphere pattern or something:
Double checked that it seems to be caused by this PR, at least when merged on top of latest develop.
Aug 21, 2016
1 check passed
added a commit
this pull request
Aug 21, 2016
Merged! Discussed briefly with @tdgunes on Slack and the one problematic Node was reverted for the time being, seems there's something quirky about the original. No surprise there - it'll take time to unravel all the spiderwebs that built up over the years :-)