Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
New block families - rebased #3343
Refresh of #3149 that has been rebased on latest develop as of this PR submission. See it for most the details. Summary of outstanding issues:
Related/updated module PRs
These seem to make the modules work, or at least compile. Some module sets can't be run fully yet without more fixes.
PRs exist but need more work
Early versions of the needed changes were submitted here, but later went out of date as the new system evolved further
Modules that still need a PR to fix related code
These need basic review akin to one of the GCI tasks that resulted in a bunch of the above PRs. Can review some of those PRs to see the likely changes to the modules in this list
Can't compile due to broken dependencies. Could be fine after dependencies fixed (yep, seemingly build now after the GF compile fix)
Also: potentially any module that uses block families the old school way in prefabs rather than define their own unique block families thus causing compilation errors. I haven't looked for those, nor have I done any specific play testing of affected block families beyond the basics (torch, stairs, fences...)
Use this rebased branch for testing modules. The older branch predates the big v2 engine merge and will show dependency issues on a large amount of modules due to version bumps made later.
Might be of particular interest to @asiekierka who may refactor further in the area as part of GSOC 2018