New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New block families - rebased #3343

Merged
merged 25 commits into from May 26, 2018

Conversation

Projects
None yet
10 participants
@Cervator
Member

Cervator commented Apr 27, 2018

Refresh of #3149 that has been rebased on latest develop as of this PR submission. See it for most the details. Summary of outstanding issues:

Related/updated module PRs

These seem to make the modules work, or at least compile. Some module sets can't be run fully yet without more fixes.

PRs exist but need more work

Early versions of the needed changes were submitted here, but later went out of date as the new system evolved further

  • Terasology/Signalling#17
  • Terasology/Machines#25 - also clashes with the changes in #3221 and is a bit more work than I can put in right now (complex family with all faces and an archetype, logic defines it all over several passes, hard to readily tweak)

Modules that still need a PR to fix related code

These need basic review akin to one of the GCI tasks that resulted in a bunch of the above PRs. Can review some of those PRs to see the likely changes to the modules in this list

  • GrowingFlora - this one is fairly central, would be a first good target so we can test other modules that have this one in their dependency tree. New PR: Terasology/GrowingFlora#12 - NeoTTA works with this but all tree branches lack their "pipe" shape?
  • TutorialAssetSystem (and probably its wiki as well)
  • ItemPipes
  • LightAndShadow
  • Minesweeper - seemingly just needs a standard family update
  • ModularComputers - single method no longer matches a signature
  • Rails
  • Sample - special since it has several old families from GCI including PRs to update
  • StructuralTemplates

Unknown

Can't compile due to broken dependencies. Could be fine after dependencies fixed (yep, seemingly build now after the GF compile fix)

  • Lost - probably OK, fails from GrowingFlora not building
  • NeoTTA - probably OK, fails from GrowingFlora not building
  • WoodAndStone - probably OK, fails from GrowingFlora not building

Also: potentially any module that uses block families the old school way in prefabs rather than define their own unique block families thus causing compilation errors. I haven't looked for those, nor have I done any specific play testing of affected block families beyond the basics (torch, stairs, fences...)

Further testing

Use this rebased branch for testing modules. The older branch predates the big v2 engine merge and will show dependency issues on a large amount of modules due to version bumps made later.

Might be of particular interest to @asiekierka who may refactor further in the area as part of GSOC 2018

@Cervator Cervator added this to the v2.0.0 milestone Apr 27, 2018

Cervator added a commit that referenced this pull request May 26, 2018

@Cervator

This comment has been minimized.

Member

Cervator commented May 26, 2018

This has been merged now - prepare for broken things :-)

Going to be updating/merging modules for a while longer. I fixed some minor quality issues via d0c852d and will create a new follow-up issue with the remaining requests from here

@Cervator Cervator deleted the newBlockFamiliesRebased branch May 26, 2018

Cervator added a commit to Terasology/AdditionalRails that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/AdventureAssets that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/CopperAndBronze that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/GooeysQuests that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/FunnyBlocks that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/HjerlHede that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/StructureTemplates that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/JoshariasSurvival that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/StoneCrafting that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/WoodAndStone that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/WoodCrafting that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/EdibleFlora that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/ManualLabor that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/Valentines that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/Lost that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/IRLCorp that referenced this pull request May 26, 2018

Cervator added a commit to Terasology/JoshariasSurvival that referenced this pull request May 27, 2018

Cervator added a commit to Terasology/LightAndShadowResources that referenced this pull request May 27, 2018

Cervator added a commit to Terasology/StructureTemplates that referenced this pull request May 27, 2018

Cervator added a commit to Terasology/LightAndShadow that referenced this pull request May 27, 2018

Cervator added a commit to Terasology/AnotherWorldPlants that referenced this pull request May 27, 2018

@Cervator Cervator referenced this pull request May 27, 2018

Closed

Final block family tweaks needed before v2.0.0 release #3374

11 of 18 tasks complete
@Cervator

This comment has been minimized.

Member

Cervator commented May 27, 2018

Done! At least with what will be handled on this one. Yay!

See #3374 for follow-ups, I've tried to catch all the outstanding issues from here not yet fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment