Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Merge pull request #3589 from Adrijaned/loadProcessDoc #3589
removed NOP loadProcesses, docced implementors of StepBasedLoadProcess + the class itself, nothing implements directly LoadProcess anymore
How to test
Test nothing broke
Outstanding before merging
None of these is blocker, so might as well be left for another PR to make this one easily testable and reviewable
Can confirm this doesn't cause any syntax errors, even in a mega-workspace with the server facade present. Nice!
However, it worries me a bit that those three classes,
I did hit a few issues, although I'm not totally sure if they're legit or just quirky. Specifically I keep hitting NPEs involving
Oddly I can start a headless server via the server facade just fine. It might involve a player actually starting in a world causing chunks to generate or other init code of some sort?
Some fuller snippets follow:
I'm getting the NPE @Cervator mentioned even when only the Core module is active. I also get it when I run a headless server from IntelliJ.
This was when I had Core, MTE and WildAnimalsGenome active, but I got the same error in all cases.
I honestly believe these cachings were introduced far in history to somehow cache the assets before the current asset system. After close inspection, the code for block caching was introduced by @immortius way back in 2012 in 76ed8b0 , and remained unchanged since then. I couldn't find any side effects the code might be causing now, so removing it.