Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAG DependencyConnection draft #3680

Draft
wants to merge 81 commits into
base: develop
from

Conversation

5 participants
@dave2s
Copy link
Contributor

commented May 28, 2019

DO NOT MERGE

Contains draft for not yet created issue. Drafting dependency connections for DAG
### Graph progress marked here, use this to navigate code too

  • Figure EdgeConnection storing and push this forward.
  • Remove current mechanics for dependency storing and loading.
  • Remove direct FBO passing. Only causes trouble.
  • Discuss naming of this feature and classes. Since the proposed naming of sockets/plugs makes more sense than connections because connections would live outside the scope of nodes and nodes would be attributed to these connections, which is not the case.
    Discuss progress
@dave2s

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

Do not sift trough the code until I push another update. This was first drafting and is not going to be pushed forward in this direction. I'm not going to comment this yet

@dave2s dave2s added this to Backlog in GSOC 2019: DAG May 28, 2019

@dave2s dave2s moved this from Backlog to In progress in GSOC 2019: DAG May 28, 2019

@dave2s dave2s moved this from In progress to Month 3 in GSOC 2019: DAG May 28, 2019

@dave2s dave2s moved this from Month 3 to Backlog in GSOC 2019: DAG May 28, 2019

@dave2s dave2s moved this from Backlog to Month 1 in GSOC 2019: DAG May 28, 2019

@dave2s dave2s moved this from Month 1 to In progress in GSOC 2019: DAG May 28, 2019

@GooeyHub

This comment has been minimized.

Copy link
Member

commented May 28, 2019

Hooray Jenkins reported success with all tests good!

@dave2s dave2s changed the title DAG EdgeConnection draft DAG DependencyConnection draft May 28, 2019

dave2s added some commits May 28, 2019

moved getFboName(int) naming from super class to FboConnection.java,
removed createFBOConnection methods from super class
rename FBOConnection.java to FboConnection.java
rename EdgeConnection to DependencyConnection
updated FboConnection to store FBO fboData and updated get/set methods
FinalPostProcessingNode - read input fbo from added FboConnection
restored fbousages for new abstract nodes for now
update passtroughNode with mandatory setDependencies() method to compile without errors
@dave2s

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

I should store DependencyConnection connectedToConnection instead of SimpleUri connectedNode as DependencyConnection's attribute. Since I need to get to both connected node and it's connection...since connection now has it's parent - I can query the connection for it's parent

dave2s added some commits Jun 13, 2019

RenderGraphAPI ++public reconnectInputFboToOutput() ver.1. majority o…
…f logic private reconnectIFTO() - should be Node's or Connection's method

This class should implement interface which should be used in its place within the modules.
rename Node interface's connection method, use Abstract DependencyCon…
…nection class here to make it generic

update classes for this change
Dep.Con. to DependencyConnection<T>, FboConnection extends DC<FBO>, D…
…C has T data;

FboConnection:
-- ~get/setData()~, only inherits now,
++ overrides getConnectionName() returns FBO.append(id)
DependencyConnection:
-- SimpleUri connectedNode
++ DependencyConnection connectedConnection + associated getter/setter
++ reconnectInputConnectionToOutput();
++ T getData(), setData(T data),
NewAbstractNode update: read below
getInput/OutputFboData to use static FboConnection.getConnectionName(id) to obtain FBO name
++private boolean addInputConnectoin()
++reflect previous FboConnection changes in method names
++setConnectedConnection on addInputFboConnection() call
m connectFbo() to connect()
update protected FBO requiresFbo before removing it so it adds a connection
rendergraphapi,newabstractnode - finalize dependency reconnecting for…
… fbos, lacks rendergraph update, not yet wip

NewNode ++ reconnectInputFboToOutput()
RenderGraphApi ++disconnectInput/OutputFbo(),Dep.Connection ++disconn…
…ect();NewAbstractNode ++ disconnectOutputFbo
WorldRendererImpl - renderDagApi rename + usage of interface
Create api and store it's interface to context to use in modules.
 public RenderDagApiInterface renderDagApi;
   renderDagApi = RenderDagApi.getRenderDagApi(renderGraph);
   context.put(RenderDagApiInterface.class, renderDagApi);
RenderDagApi rename + remove old type of injection (share) + implemen…
…ts its Interface now

disconnecting dependencies logs success.
Change RenderDagApi.removeNode()'s SimpleUri arg to String
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.