Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisualCharacterSystemTest Fix and Whitelist PermissionManager #3695

Merged
merged 2 commits into from Jun 27, 2019

Conversation

@darshan3
Copy link
Member

commented Jun 27, 2019

Contains

Fixes the currently failing testSendingOfCreateVisualCharacterEvent in VisualCharacterSystemTest.
Also, whitelists the PermissionManager class for it to be used by modules.

How to test

Run testSendingOfCreateVisualCharacterEvent in VisualCharacterSystemTest

@GooeyHub

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

Hooray Jenkins reported success with all tests good!

@darshan3 darshan3 changed the title VisualCharacterSystemTest Fix VisualCharacterSystemTest Fix and Whitelist PermissionManager Jun 27, 2019

@GooeyHub

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

Hooray Jenkins reported success with all tests good!

@Cervator Cervator added this to the v2.3.0 milestone Jun 27, 2019

@Cervator Cervator merged commit 07cda61 into MovingBlocks:develop Jun 27, 2019

2 checks passed

LGTM analysis: Java No new or fixed alerts
Details
default Build finished.
Details

@Cervator Cervator added Api Bug labels Jun 27, 2019

@Cervator

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

Tested verified, and merged! APIT tweak ready for more L&S fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.