Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collective behavior trees #3708

Merged
merged 4 commits into from Jul 27, 2019

Conversation

@casals
Copy link
Contributor

casals commented Jul 23, 2019

Contains

  • Additions and small changes in the org.terasology.logic.behavior package.

Objective

To create a collective beehavior structure capable of interpreting a single behavior tree for a group of actors. This was necessary due to some restrictions found in the original group model while working on the last tasks of Milestone #2. The scenario is discussed in the GSoC Milestone 2 blog post.

Changes

The following classes were added to the engine:

  • org.terasology.logic.behavior.core.CollectiveBehaviorTreeRunner

  • org.terasology.logic.behavior.DefaultCollectiveBehaviorTreeRunner

  • org.terasology.logic.behavior.CollectiveInterpreter

  • org.terasology.logic.behavior.CollectiveBehaviorComponent

Also:

  • the interface Callback was extracted from org.terasology.logic.behavior.DefaultBehaviorTreeRunner (not being used yet)

  • copy constructors were added to the classes CollectiveInterpreter and Interpreter. This change is related to the task involving persistence of a behavior tree execution state for a single entity.

Usage

  • Install the module [WildAnimalsMadness] (PR 31 for WildAnimals must be merged)

  • Create/load a game using the module WildAnimalsMadness

  • Execute the command groupTestThree

@GooeyHub

This comment has been minimized.

Copy link
Member

GooeyHub commented Jul 23, 2019

Can one of the admins please verify this patch?

@pollend

This comment has been minimized.

Copy link
Member

pollend commented Jul 23, 2019

can you remove all the .iml files those are generated by gradle when you run ./gradlew idea. those shouldn't be included in the PR.

@casals

This comment has been minimized.

Copy link
Contributor Author

casals commented Jul 23, 2019

Hm, that should have been ignored - didn't realize it, sorry. Removing them now.

@pollend

This comment has been minimized.

Copy link
Member

pollend commented Jul 27, 2019

this looks pretty good @dkambersky is it ok to merge this.

@dkambersky

This comment has been minimized.

Copy link
Member

dkambersky commented Jul 27, 2019

A 👍 from me (but I don't have write access to merge it)

@pollend pollend merged commit 32960b0 into MovingBlocks:develop Jul 27, 2019
1 check passed
1 check passed
LGTM analysis: Java No new or fixed alerts
Details
@pollend pollend added this to the v2.3.0 milestone Jul 27, 2019
@Cervator

This comment has been minimized.

Copy link
Member

Cervator commented Jul 27, 2019

(but I don't have write access to merge it)

@dkambersky You do now! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.