Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New asset: Group #3717

Merged
merged 3 commits into from Aug 10, 2019

Conversation

@casals
Copy link
Contributor

casals commented Aug 8, 2019

Contains

  • New asset: Group
  • Updates the build with gestalt version 5.1.4 (required by asset structure)

Objective

  • The new Group asset allows group configurations to be loaded from JSON files (assets/groups/.group).
  • Gestalt 5.1.4 contains a fix to a bug that would sometimes prevent an asset file to be loaded. This error appears as an java.security.AccessControlException exception ("access denied"), with the stack trace leading to org.terasology.assets.format.AssetDataFile.openStream(AssetDataFile.java:99) .

Changes

  • New asset structure: Group, GroupBuilder, GroupData, GroupFactory, and GroupFormat. The new implementation is hermetic and shouldn't affect any of the existing classes.
  • Updates both gestalt-module and gestalt-asset-core to version 5.1.4 in build.gradle

Usage

  • Make sure to thoroughly rebuild the project to avoid broken references using gradlew clean cleanIdea idea jar (so that the new gestalt version can be properly used)
  • The new asset structure is demonstrated in the WildAnimalsMadness module
@GooeyHub

This comment has been minimized.

Copy link
Member

GooeyHub commented Aug 8, 2019

Can one of the admins please verify this patch?

@casals casals changed the title Updated: Gestalt New Group assets Aug 8, 2019
@casals casals changed the title New Group assets New asset: Group Aug 8, 2019
@Cervator

This comment has been minimized.

Copy link
Member

Cervator commented Aug 8, 2019

@GooeyHub: add to whitelist

@GooeyHub

This comment has been minimized.

Copy link
Member

GooeyHub commented Aug 8, 2019

Hooray Jenkins reported success with all tests good!

Copy link
Member

Cervator left a comment

Fairly trivial comments, solid PR otherwise 👍

If you don't mind and have the time a quick rebase to squash the merge commits would also be appreciated :-)

Still pending testing as my workspace broke for other reasons

@GooeyHub

This comment has been minimized.

Copy link
Member

GooeyHub commented Aug 9, 2019

Hooray Jenkins reported success with all tests good!

2 similar comments
@GooeyHub

This comment has been minimized.

Copy link
Member

GooeyHub commented Aug 9, 2019

Hooray Jenkins reported success with all tests good!

@GooeyHub

This comment has been minimized.

Copy link
Member

GooeyHub commented Aug 9, 2019

Hooray Jenkins reported success with all tests good!

@casals casals force-pushed the casals:develop branch from 127492a to edfcbe3 Aug 9, 2019
@casals

This comment has been minimized.

Copy link
Contributor Author

casals commented Aug 9, 2019

Removed leftovers from the previous gestalt debugging (including generic exceptions, replaced with more appropriate ones) and included javadoc for classes/fields. Also rebased to remove merge commits.

@casals casals force-pushed the casals:develop branch from edfcbe3 to aedb055 Aug 9, 2019
@GooeyHub

This comment has been minimized.

Copy link
Member

GooeyHub commented Aug 9, 2019

Hooray Jenkins reported success with all tests good!

1 similar comment
@GooeyHub

This comment has been minimized.

Copy link
Member

GooeyHub commented Aug 9, 2019

Hooray Jenkins reported success with all tests good!

@casals casals force-pushed the casals:develop branch from aedb055 to 7ce2b0f Aug 9, 2019
@casals casals force-pushed the casals:develop branch from 7ce2b0f to 33455a0 Aug 9, 2019
@GooeyHub

This comment has been minimized.

Copy link
Member

GooeyHub commented Aug 9, 2019

Hooray Jenkins reported success with all tests good!

@GooeyHub

This comment has been minimized.

Copy link
Member

GooeyHub commented Aug 9, 2019

Hooray Jenkins reported success with all tests good!

@Cervator Cervator merged commit 33455a0 into MovingBlocks:develop Aug 10, 2019
2 checks passed
2 checks passed
LGTM analysis: Java No new or fixed alerts
Details
default Build finished.
Details
Cervator added a commit that referenced this pull request Aug 10, 2019
@Cervator

This comment has been minimized.

Copy link
Member

Cervator commented Aug 10, 2019

Briefly validated that the game still works after the merge, looking forward to trying it out in WildAnimalsMadness soon 👍

@Cervator Cervator added this to the v2.3.0 milestone Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.