Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added group components to the behavior package #3727

Merged
merged 2 commits into from Aug 18, 2019

Conversation

@casals
Copy link
Contributor

casals commented Aug 16, 2019

Contains

New group components. This relates directly with PR #3717 and with WildAnimalsMadness PR #1.

Objective

The new Group components were created as part of the WildAnimalsMadness module. After testing the different grouping scenarios they are ready to me moved into the behavior package as originally intended.

Changes

  • New component: GroupTag
  • New component: GroupMind
@GooeyHub

This comment has been minimized.

Copy link
Member

GooeyHub commented Aug 16, 2019

Hooray Jenkins reported success with all tests good!

import java.util.HashSet;
import java.util.Set;

public class GroupMindComponent implements Component {

This comment has been minimized.

Copy link
@eviltak

eviltak Aug 17, 2019

Member

Is it possible to document this component now, or will it be done later?

This comment has been minimized.

Copy link
@casals

casals Aug 17, 2019

Author Contributor

Sorry, didn't realize it was missing - fixed with additional commit.

Copy link
Member

eviltak left a comment

Looks well documented to me! Merging after the build finishes.

@GooeyHub

This comment has been minimized.

Copy link
Member

GooeyHub commented Aug 17, 2019

Hooray Jenkins reported success with all tests good!

@eviltak eviltak merged commit 388dff5 into MovingBlocks:develop Aug 18, 2019
2 checks passed
2 checks passed
LGTM analysis: Java No new or fixed alerts
Details
default Build finished.
Details
@Cervator Cervator added this to the v2.3.0 milestone Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.