Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render DAG and rendering modules architecture #3732

Open
wants to merge 196 commits into
base: develop
from
Open
Changes from 1 commit
Commits
Show all changes
196 commits
Select commit Hold shift + click to select a range
c9633d4
hmm
dave2s Apr 29, 2019
e8248da
playing with some things
dave2s May 17, 2019
b7e409a
mend
dave2s May 17, 2019
1f4fa2b
drafted methods for adding connections to new abstract node
dave2s May 17, 2019
78c997a
init input output connections variables in new abstract node
dave2s May 17, 2019
a9dac0c
remove connections, get number of connections, get list of input/outp…
dave2s May 17, 2019
fc5a4f4
Comment out DAG dependency matching draft
dave2s May 23, 2019
9bfbd1c
depndendency get/set->public, constructor on top
dave2s May 23, 2019
cb03399
finalpostprocessingnode->extends newabstractnode,++passtrough node
dave2s May 23, 2019
04bd2ae
Switch to new abstract node super type for some testing nodes late in…
dave2s May 23, 2019
c76c24d
Faulty design atm, contains the usage idea behind newabstractnode cha…
dave2s May 23, 2019
d2715dc
Methods for tampering with in/out dependencies input getting protecte…
dave2s May 23, 2019
ffc417c
connection names from Name to String. Might construct some Uri class …
dave2s May 23, 2019
a8b64f5
Reading FBO inputs inside a specific node to try and run.
dave2s May 23, 2019
2b855f4
mainly checkstyle
dave2s May 28, 2019
8f91b98
merge PR-edgeConnections into edgeConnections and apply previous edge…
dave2s May 28, 2019
304f0ef
Revert ConditionDependentNode update to new system for the time being
dave2s May 28, 2019
21d0bfd
New DependencyConnection abstract class, renamed from EdgeConnection
dave2s May 28, 2019
4e1796a
moved getFboName(int) naming from super class to FboConnection.java,
dave2s May 28, 2019
33feec1
removed materialconnection for now
dave2s May 28, 2019
3315b57
FinalPostProcessingNode - read input fbo from added FboConnection
dave2s May 28, 2019
19a799f
Connect toneMappingNode out FBO1 to finalPostProcessingNode input FBO1
dave2s May 28, 2019
703eb83
set output FBO connection for ToneMappingNode
dave2s May 28, 2019
3e4338a
checkstyle
dave2s May 29, 2019
f7f2c84
checkstyle
dave2s May 29, 2019
d87ded5
Split old Node to NewNode interfaces
dave2s May 31, 2019
78ca970
Update nodes to extend NewAbstractNode implement NewNode
dave2s May 31, 2019
2fd6115
Connected input dependencies(some gbuffers are still passed the old w…
dave2s May 31, 2019
5d92cc7
Call NewNode.setDependencies() when adding new NewAbstractNode to the…
dave2s May 31, 2019
db44fd9
Updated NewAbstractNode:
dave2s May 31, 2019
d407150
Update RenderTaskListGenerator to use NewNode
dave2s May 31, 2019
502d3b4
Update RenderTaskListGeneratorTest to NewNode,
dave2s May 31, 2019
8734d3f
Following changes to NewNode/NewAbstractNode system utilize new manda…
dave2s May 31, 2019
029240f
DownSamplerNodes to new dependency system, read below:
dave2s May 31, 2019
82a425a
unused import --
dave2s May 31, 2019
60fae0d
restore dispose for new abstract node and fboUsages since a lot of no…
dave2s May 31, 2019
73a3294
newAbstractNode - make some connection queries public, getInputConn.-…
dave2s Jun 4, 2019
9ebfb3b
WorldRendererImpl checkstyle
dave2s Jun 4, 2019
445990d
Class level Refactor FBOConfig -> FboConfig
dave2s Jun 4, 2019
96f5aeb
Class level refactor: *FBOs* -> {0}Fbo{1}
dave2s Jun 4, 2019
79be36b
WorldRendererImpl variables rename *FBOs -> *Fbo
dave2s Jun 4, 2019
97e8eec
amend last commit
dave2s Jun 4, 2019
705c6b2
Added parentNode and connectedNode attributed to connections.Read below
dave2s Jun 7, 2019
91683c2
setConnected node access modifier to protected
dave2s Jun 7, 2019
a78e0a3
toString() override for DependencyConnection
dave2s Jun 7, 2019
058a430
connectFbo-++check for already connected + setting connection.connect…
dave2s Jun 7, 2019
a218fbb
parentNode setter for DependencyConnections
dave2s Jun 7, 2019
261e8cd
Double check for FBO connecting, read below:
dave2s Jun 7, 2019
677fca0
remove comments
dave2s Jun 7, 2019
d8e00a8
remove unused commented code from RenderGraph.java
dave2s Jun 7, 2019
776524c
add a multiplicative tint shader
dave2s Jun 10, 2019
329b4a7
WorldRendererImpl.java: force a tintNode between finalPostProcessing …
dave2s Jun 10, 2019
b839a1a
Draft an API class with access to the DAG to attempt dag tampering fr…
dave2s Jun 10, 2019
d05b08c
moved some classes around packages - api experiments
dave2s Jun 13, 2019
7d0a802
render graph imports NewNode
dave2s Jun 13, 2019
31c4d3d
update method declarations to RenderTaskListGeneratorTest to compile …
dave2s Jun 13, 2019
a611325
RenderTaskListGenerator imports NewNode
dave2s Jun 13, 2019
7ec002d
RenderGraphAPI ++public reconnectInputFboToOutput() ver.1. majority o…
dave2s Jun 13, 2019
b0ad628
rename Node interface's connection method, use Abstract DependencyCon…
dave2s Jun 13, 2019
a98db7f
logger warn to info, comment out Runtime exception when output connec…
dave2s Jun 13, 2019
5b020ef
dag/api/package-info.java @API annot.
dave2s Jun 13, 2019
e828172
Dep.Con. to DependencyConnection<T>, FboConnection extends DC<FBO>, D…
dave2s Jun 13, 2019
0aa3543
deapify DAG packages
dave2s Jun 13, 2019
88b5ea5
++ FBO.java toString()
dave2s Jun 13, 2019
ab13784
NewNode -> from dag.gsoc to dag.api
dave2s Jun 13, 2019
451179b
NewAbstractNode update: read below
dave2s Jun 13, 2019
4bdc98f
DownSamplerNode update data obtaining call name
dave2s Jun 13, 2019
92188f8
m RenderTaskListGeneratorTest modified to compile
dave2s Jun 13, 2019
7e3217e
rendergraphapi,newabstractnode - finalize dependency reconnecting for…
dave2s Jun 13, 2019
d1e5b45
RenderGraphApi ++disconnectInput/OutputFbo(),Dep.Connection ++disconn…
dave2s Jun 13, 2019
f302345
DependencyConnection reconnectInputConnectionToOutput-write to data d…
dave2s Jun 13, 2019
b51b386
DependencyConnection -- getConnectionName commented out for the time …
dave2s Jun 13, 2019
b6e6bdd
render graph api disconnect() todos
dave2s Jun 13, 2019
1e2955c
rename RenderGraphApi to RenderDagApi
dave2s Jun 14, 2019
5a093de
++ RenderDagApiInterface
dave2s Jun 14, 2019
32db02f
WorldRendererImpl - renderDagApi rename + usage of interface
dave2s Jun 14, 2019
0e98404
RenderDagApi rename + remove old type of injection (share) + implemen…
dave2s Jun 14, 2019
8e7f98c
FboConnection - remove unused lines
dave2s Jun 14, 2019
086542a
DependencyConnection for output connection disconnecting - leave data
dave2s Jun 14, 2019
3ac382d
AbstractNode temporary workaround for reusing dependencies after modu…
dave2s Jun 14, 2019
fee7cab
RenderDagApi javadoc draft
dave2s Jun 14, 2019
eddf315
remove TintNode from engine, rename node.connect to connectFbo
dave2s Jun 20, 2019
f2e0a77
return @API annotation to dag package classes
dave2s Jun 20, 2019
8b93828
RenderTaskListGenerator[Test] - update generator to write debug logs,…
dave2s Jun 20, 2019
f5d4aec
RenderGraph - ++ boolean areConnected(node,node), store renderGraph i…
dave2s Jun 20, 2019
af05997
RenderDagApi+Interface - ++ 2x findNode(),2x resetDesiredStateChanges(),
dave2s Jun 20, 2019
cfc2330
add toString to FboConnection()
dave2s Jun 20, 2019
9bf45af
DependencyConnection - fix ToString() nullpointer exception, improve …
dave2s Jun 20, 2019
d60d39f
NewAbstractNode add setRenderGraph()
dave2s Jun 20, 2019
cbaecc9
Nodes - ++ resetDesiredStateChanges()
dave2s Jun 20, 2019
133ebd5
NewAbstractNode ++ isDependentOn()
dave2s Jun 20, 2019
0a103cd
Nodes-rename connect to connectFbo(), improve and fixup connectFbo() …
dave2s Jun 20, 2019
1824ff8
PropertyChangeEvent and PropertyChangeListener @API wrapper draft
dave2s Jun 20, 2019
e42146e
shaderManager ++ addShader(String title, Name moduleName), overload i…
dave2s Jun 21, 2019
babb030
updated RenderDagApi interface with addShader() and shaderManager inj…
dave2s Jun 21, 2019
45b2811
New ModuleRenderingSystem extending BaseComponentSystem, encapsulates…
dave2s Jun 21, 2019
48cfc44
checkstyle + some access modifiers: RenderGraph.java, DependencyConne…
dave2s Jun 21, 2019
21c74a9
whitelist for java.beans (nodes need propertyChangeListener/Events)
dave2s Jun 27, 2019
c239d23
remove tint shader (moved to dagTestingModule)
dave2s Jun 27, 2019
98f39c1
Merge RenderDagApi with RenderGraph. Remove RenderDagApi and it's imp…
dave2s Jun 27, 2019
19c106f
NewAbstractNode isDepdendentOn() fixed wrong object comparing
dave2s Jun 27, 2019
d7cc2c5
NewAbstractNode.isDependentOn() now compares node uris
dave2s Jun 27, 2019
ff071df
accidentally committed .ini file removal
dave2s Jun 27, 2019
914064a
RenderTaskListGenerator - trim a little debug output for the tests to…
dave2s Jun 27, 2019
c712d67
moving nodes to basicrendering - save up for pc swap
dave2s Jul 4, 2019
d21098d
@API + WhiteListing for All current rendering nodes' needs after movi…
dave2s Jul 6, 2019
8b6e9d2
GLSLShader.java temporary hardcoded SSAO param for preprocessorpreamble
dave2s Jul 6, 2019
e81c010
Replace RefractiveReflectiveBlocksNode with dummy RRBNProxy containin…
dave2s Jul 6, 2019
dc686bf
Rename ModuleRenderingSystem to ModuleRendering
dave2s Jul 6, 2019
cb3c253
add BufferPairConnection draft
dave2s Jul 7, 2019
29df4fe
rendergraph connecting + refactoring nodes' dep. connecting wip PC sw…
dave2s Jul 8, 2019
a2a2601
RenderGraph ++getNodeMapSize(),2xconnectBufferPair(),
dave2s Jul 14, 2019
1ac9498
Update BufferPairConnection getConnectionName()with module:node:, sho…
dave2s Jul 14, 2019
abe21d0
AbstractNode ++ handling bufferPairConnections, reflect previous comm…
dave2s Jul 14, 2019
0ebd298
WorldRendererImpl - checkstyle + add commented renderGraph init check…
dave2s Jul 14, 2019
22f06dd
remove old unused class RenderDagApi
dave2s Jul 15, 2019
fb30e11
TODO for renderGraph. SetDependency and Connecting will have to be so…
dave2s Jul 15, 2019
b297e4e
++ BufferPair.java hiding Pair<FBO,FBO> as DependencyConnection Data …
dave2s Jul 15, 2019
7e5b16a
BufferPairConnection update with BufferPair data type, shift getPrima…
dave2s Jul 15, 2019
f699c04
Update ModuleRendering to be extended by BasicRenderingModule and add…
dave2s Jul 15, 2019
85c2f7b
New RunOrderConnection extends DependencyConnection...is usefull for …
dave2s Jul 16, 2019
c4bdb8c
update BufferPairConnection - copySwapped->getSwappedCopy(DependencyC…
dave2s Jul 16, 2019
6b496e5
Update createBufferPair to take less arguments, strip off the redunda…
dave2s Jul 16, 2019
d58d5b2
WorldRendererImpl ++ commented out dummy nodes...WIP
dave2s Jul 22, 2019
390a188
RenderGraph(multiline comment): reconnectFbo,BufferPair,RunOrder to r…
dave2s Jul 22, 2019
4f2cffa
DependencyConnection - update connectedConnection to map of connected…
dave2s Jul 22, 2019
abeb22e
DummyNode draft
dave2s Jul 22, 2019
a738760
engine ModuleRendering.java (extended by rendering modules) call late…
dave2s Jul 22, 2019
06682c2
RunOrderConnection - not sure if we need this TODO
dave2s Jul 22, 2019
4486857
Node interface ++ new methods getInputConnections(), getOutputConnect…
dave2s Jul 22, 2019
54ca534
NewAbstractNode- update constructors with aka, ++ getInput/OutputConn…
dave2s Jul 22, 2019
39fad6d
add providing module to node's constructors in order to know which mo…
dave2s Jul 24, 2019
c68de2e
draft of command dagRedirectFbo -WorldRendererImpl + RenderGraph reco…
dave2s Jul 24, 2019
8757f38
remove unused node draft
dave2s Jul 24, 2019
e2115c4
AbstractNode + Node ++ clearStateChanges(), fix output data propagati…
dave2s Jul 25, 2019
ac52ca4
new node clearDesiredStateChanges() - ammend to a few commits back
dave2s Jul 25, 2019
f86f4a3
renderGraph update reconnectInputFboToOutput with boolean disconnectP…
dave2s Jul 25, 2019
8aed808
DependencyConnection rename argument to fromConnection
dave2s Jul 25, 2019
74a1281
WorldRendererImpl update dagRedirectFbo with toNode.clearDesiredState…
dave2s Jul 25, 2019
f35f7e4
draft of initializationPriority for renderingModules
dave2s Jul 27, 2019
fb595e9
ModuleRendering remove order calculation, add get/set init priority
dave2s Jul 29, 2019
dcfd124
rendering-settings menu_en/cs.lang
dave2s Jul 29, 2019
c63af16
renderingModuleSettingScreen.java logic behind rendering setting draft
dave2s Jul 29, 2019
22818b4
startPlayingScreen.ui - incorporate renderingSettingButton
dave2s Aug 6, 2019
d220e4a
menu_en.lang,menu_cs.lang - add "return", add "rendering-settings"
dave2s Aug 6, 2019
4d60543
introduce renderingModuleScreen.ui and .java for configuration of ren…
dave2s Aug 6, 2019
992041a
WorldRendererImpl.java - add rendering modules' initialization in order
dave2s Aug 6, 2019
72d244c
TerasologyEngine.java add ModuleRenderingSubsystem
dave2s Aug 6, 2019
5fdb0d6
++ModuleRenderingSubsystem.java > ++ ModuleRenderingManager.java > ++…
dave2s Aug 6, 2019
9c3abd0
ModuleRendering - update - does not extend BaseComponentSystem, get p…
dave2s Aug 6, 2019
f542905
StartPlayingScreen.java add callback for renderingSettings button
dave2s Aug 6, 2019
44e0e86
RenderingModuleManager change package
dave2s Aug 7, 2019
73b04de
RenderingModuleRegistry change package
dave2s Aug 7, 2019
554673b
@APIfy module/rendering/ package
dave2s Aug 7, 2019
b3d0bbe
ModuleRenderingSubsystem update import's package path
dave2s Aug 7, 2019
1690391
WorldRendererImpl.java - update rendering modules' initializations
dave2s Aug 7, 2019
bdbedae
RenderingModuleSettingScreen.java update import's paths
dave2s Aug 7, 2019
904c7b1
ModuleRendering.java set context in constructor, don't store ModuleRe…
dave2s Aug 7, 2019
c7f89c5
RenderingModuleRegistry.java - commented out gamerun-context put() ca…
dave2s Aug 7, 2019
fa96aa9
RenderingModuleRegistry.java patch ModuleRendering fetching - searche…
dave2s Aug 9, 2019
2a89287
moduleRendering.java visibility for attribute lowered to protected
dave2s Aug 9, 2019
f408cba
StartPlayingScreen.java renderingSettingScreen creation patchup, chec…
dave2s Aug 9, 2019
b18394c
RenderingModuleSettingScreen.java + renderingModuleSettingScreen.ui, …
dave2s Aug 9, 2019
ca3a31e
RenderingModuleSettingScreen.java change toStrings for distinguishabi…
dave2s Aug 10, 2019
cfb782b
worldRendererImpl add support for rendering class enabled/disabled at…
dave2s Aug 12, 2019
0f12e88
menu_cs and menu_en lang add disable-rendering-class/enable-renderin…
dave2s Aug 12, 2019
1fbc3f2
checkstyle
dave2s Aug 12, 2019
18ebc2c
update renderingModuleSettingScreen ui and java with Enable/Disable b…
dave2s Aug 12, 2019
b05e155
ModuleRendering.java add boolean isEnabled attribute, isEnabled() and…
dave2s Aug 12, 2019
b48ee1a
Nodes now implicitly try to pass bufferpairconnection if it's been in…
dave2s Aug 23, 2019
c50a8ee
WorldRendererImpl.java add logger, log rendering initialisation
dave2s Aug 23, 2019
497f10a
refactor/generalize api methods for reconnecting, reflect this in wor…
dave2s Aug 23, 2019
3bef0b2
RenderGraph ++ late connection building based on all nodes' dependenc…
dave2s Aug 23, 2019
2e576ae
RenderGraph.java patch reconnectFbo and reconnectRunOrder, not used atm
dave2s Aug 23, 2019
61f4b8c
RenderGraph.java update, disconnectOutputFboConnection, update discon…
dave2s Aug 23, 2019
333d7bb
Fix giant problem for late graph connecting - wrong connection added,…
dave2s Aug 23, 2019
862fa32
DependencyConnection.java utility method for parsing connection id, T…
dave2s Aug 23, 2019
bf117b1
renderGraph.java ammend 3 line extra header removal of disconnectFbo(…
dave2s Aug 23, 2019
ead646c
RenderTaskListGeneratorTest.java import BufferPair to compile
dave2s Aug 23, 2019
8b06fe6
RenderGraph.java take out explicit dag connecting. Leave late buildin…
dave2s Aug 23, 2019
4abd480
NewAbstractNode.java add logger.info for propagating data to output c…
dave2s Aug 23, 2019
257c6d6
RenderGraph ammend for removing explicit connecting
dave2s Aug 23, 2019
fc47ffd
RenderGraph.java update concurency problems in reconnectAllConnectedI…
dave2s Aug 23, 2019
39738db
replace legacy AbstractNode with GSOC version. In other words, NewAbs…
dave2s Aug 24, 2019
ed5ffed
moved AbstractNode from dag.gsoc package to dag
dave2s Aug 24, 2019
b05a290
replace legacy Node with NewNode and rename to Node again
dave2s Aug 24, 2019
5963cd8
Move ModuleRendering to dag package
dave2s Aug 24, 2019
f9c547b
move dummy node concept class to nodes package
dave2s Aug 24, 2019
6e45c6c
rename gsoc package to dependencyConnections
dave2s Aug 24, 2019
f87eec4
RenderGraph.java overload reconnectInputFboToOutput() to enable Nodes…
dave2s Aug 25, 2019
0a231bf
RenderGraph.java checkstyle
dave2s Aug 25, 2019
ce40db1
DependencyConnection.java checkstyle
dave2s Aug 25, 2019
4af9edc
BufferPair - javadoc and checkstyle
dave2s Aug 25, 2019
5e22eb5
RenderingModuleSettingScreen.java checkstyle, ++ initSlider null chec…
dave2s Aug 25, 2019
5cd4524
renderingModuleRegistry fix getModuleRenderingByModuleId() cycle whic…
dave2s Aug 25, 2019
7aa3445
RenderGraph.java javadoc for reconnectInputToOutput
dave2s Aug 25, 2019
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Methods for tampering with in/out dependencies input getting protecte…

…d, outputs getting public ..etc
  • Loading branch information...
dave2s committed May 23, 2019
commit d2715dc06a0152c51e8ef6aa97f58790fec4908e
@@ -50,8 +50,8 @@
protected boolean enabled = true;
private Set<StateChange> desiredStateChanges = Sets.newLinkedHashSet();
private Map<SimpleUri, BaseFBOsManager> fboUsages = Maps.newHashMap();
private Map<Name,EdgeConnection> inputConnections = Maps.newHashMap();
private Map<Name,EdgeConnection> outputConnections = Maps.newHashMap();
private Map<String,EdgeConnection> inputConnections = Maps.newHashMap();
private Map<String,EdgeConnection> outputConnections = Maps.newHashMap();
private final SimpleUri nodeUri;

/**
@@ -77,32 +77,54 @@ private void addInputConnection(EdgeConnection input){
private void addOutputConnection(EdgeConnection output){
this.outputConnections.putIfAbsent(output.getName(),output);
}
/**TODO String to SimpleUri or make ConnectionUri and change Strings for names to ConnectionUris*/
private String getFBOName(int number){
return new StringBuilder("FBO").append(number).toString();
}
private String getMaterialName(int number){
return new StringBuilder("Material").append(number).toString();
}

public void addInputFBOConnection(Name name, EdgeConnection.Type type, SimpleUri fboUri){
EdgeConnection fboConnection = new FBOConnection(name, type, fboUri);
protected SimpleUri getInputFBOUri(int number){
return ((FBOConnection)this.inputConnections.get((new StringBuilder("FBO").append(number).toString()))).getUri();
}

protected ResourceUrn getInputMaterialUrn(int number){
return ((MaterialConnection)this.inputConnections.get((new StringBuilder("Material").append(number).toString()))).getUrn();
}

public void addInputFBOConnection(int id, SimpleUri fboUri){
EdgeConnection fboConnection = new FBOConnection(getFBOName(id), EdgeConnection.Type.INPUT, fboUri);
addInputConnection(fboConnection);
}

public void addOutputFBOConnection(Name name, EdgeConnection.Type type, SimpleUri fboUri){
EdgeConnection fboConnection = new FBOConnection(name, type, fboUri);
public void addOutputFBOConnection(int id, SimpleUri fboUri){
EdgeConnection fboConnection = new FBOConnection(getFBOName(id), EdgeConnection.Type.OUTPUT, fboUri);
addOutputConnection(fboConnection);
}

public void addInputMaterialConnection(Name name, EdgeConnection.Type type, ResourceUrn materialUrn){
EdgeConnection materialConnection = new MaterialConnection(name, type, materialUrn);
public void addInputMaterialConnection(int id, ResourceUrn materialUrn){
EdgeConnection materialConnection = new MaterialConnection(getMaterialName(id), EdgeConnection.Type.INPUT, materialUrn);
addInputConnection(materialConnection);
}

public void addOutputMaterialConnection(Name name, EdgeConnection.Type type, ResourceUrn materialUrn){
EdgeConnection materialConnection = new MaterialConnection(name, type, materialUrn);
public void addOutputMaterialConnection(int id, ResourceUrn materialUrn){
EdgeConnection materialConnection = new MaterialConnection(getMaterialName(id), EdgeConnection.Type.OUTPUT, materialUrn);
addOutputConnection(materialConnection);
}

public void removeInputConnection(Name name){
public SimpleUri getOutputFBOUri(int id){/**Do i need instanceof check here?*/
return ((FBOConnection)this.outputConnections.get(getFBOName(id))).getUri();
}
public ResourceUrn getOutputMaterialUrn(int id){/**Do i need instanceof check here?*/
return ((MaterialConnection)this.outputConnections.get(getMaterialName(id))).getUrn();
}

public void removeInputConnection(String name){
inputConnections.remove(name);
}

public void removeOutputConnection(Name name){
public void removeOutputConnection(String name){
outputConnections.remove(name);
}

@@ -114,22 +136,22 @@ public int getNumberOfOutputConnections(){
return this.outputConnections.size();
}

public EdgeConnection getInputConnection(Name name){
public EdgeConnection getInputConnection(String name){
return inputConnections.get(name);
}

public EdgeConnection getOutputConnection(Name name){
public EdgeConnection getOutputConnection(String name){
return inputConnections.get(name);
}

public List<Name> getInputConnections(){
List<Name> inputConnectionNameList = new ArrayList<>();
public List<String> getInputConnections(){
List<String> inputConnectionNameList = new ArrayList<>();
this.inputConnections.forEach((name,connection) -> inputConnectionNameList.add(name));
return inputConnectionNameList;
}

public List<Name> getOutputConnections(){
List<Name> outputConnectionNameList = new ArrayList<>();
public List<String> getOutputConnections(){
List<String> outputConnectionNameList = new ArrayList<>();
this.inputConnections.forEach((name,connection) -> outputConnectionNameList.add(name));
return outputConnectionNameList;
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.