Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed threading issue with discord RPC #3821

Merged
merged 1 commit into from Jan 24, 2020

Conversation

@pollend
Copy link
Member

pollend commented Jan 6, 2020

I was working on a fix to address discord RPC. The RPC thread spends a majority of its time spinning on sleep. this does not seem to work on my linux machine and the RPC library is marked as depreciated by discord. The problem is Thread.sleep(1) is sleeping for 1 ms between calls.

@GooeyHub

This comment has been minimized.

Copy link
Member

GooeyHub commented Jan 6, 2020

Hooray Jenkins reported success with all tests good!

@pollend pollend changed the title WIP: ix threading issue with discord RPC WIP: fix threading issue with discord RPC Jan 6, 2020
@Qwertygiy

This comment has been minimized.

Copy link
Contributor

Qwertygiy commented Jan 22, 2020

Tested with JFR, dropped from 1.8% of all method hits without this commit, to 0 hits registered at all (< 0.11%), for DiscordRPCSystem.run(). Functionality appeared unchanged; it still sent the proper log messages.

@pollend pollend changed the title WIP: fix threading issue with discord RPC fixed threading issue with discord RPC Jan 23, 2020
@pollend

This comment has been minimized.

Copy link
Member Author

pollend commented Jan 24, 2020

@Qwertygiy do you think this is good to merge if there isn't any syntax errors in the code?

@Cervator

This comment has been minimized.

Copy link
Member

Cervator commented Jan 24, 2020

@Qwertygiy @pollend yeah if it seems simple (this does), has been tested/reviewed, and looks good - ship it! :shipit: : 🚀

@eviltak eviltak modified the milestone: v2.3.0 Jan 24, 2020
@eviltak eviltak added this to the v2.3.0 milestone Jan 24, 2020
@eviltak

This comment has been minimized.

Copy link
Member

eviltak commented Jan 24, 2020

Merging, thanks for the work @pollend!

@eviltak eviltak merged commit 6671bf5 into MovingBlocks:develop Jan 24, 2020
2 checks passed
2 checks passed
LGTM analysis: Java No new or fixed alerts
Details
default Build finished.
Details
@pollend pollend deleted the pollend:feature/discord-rpc branch Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.