Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bugfix for #198 #468

Merged
merged 1 commit into from Apr 3, 2013

Conversation

Projects
None yet
2 participants
Contributor

sdab commented Apr 2, 2013

Fixed a bug in the railgun tool. TunnelAction now cancels the activate event if it ends up destroying no blocks. I also increased its priority to HIGH so that PlaySoundAction is lower than it. The result is that an explosion sound will only play if the railgun actually destroys blocks.

See my comment in issue #198 for more detail. Let me know if you need me to change anything in the pull request.

@sdab sdab Fixed a bug in the railgun tool. TunnelAction now cancels the activat…
…e event if it end up destroying no blocks. I also increased its priority to HIGH so that PlaySoundAction is lower than it. The result is that an explosion sound will only play if the railgun actually destroys blocks
6d1e874

@Cervator Cervator added a commit that referenced this pull request Apr 3, 2013

@Cervator Cervator Merge #468 from @sdab - railgun tweaks b8d922a

@Cervator Cervator merged commit 6d1e874 into MovingBlocks:develop Apr 3, 2013

Owner

Cervator commented Apr 3, 2013

Appreciated - you should introduce yourself in the forum sometime, also a good place to discuss bigger things if you're planning to stay around a while :-)

http://forum.movingblocks.net/forums/contributor-introductions.7/

@sdab sdab deleted the sdab:integrate branch Apr 3, 2013

Contributor

sdab commented Apr 3, 2013

Ah, thanks will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment