Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check availability before fetching information #433

Open
skaldarnar opened this issue Jun 17, 2019 · 1 comment

Comments

2 participants
@skaldarnar
Copy link
Member

commented Jun 17, 2019

The launcher fails to start if a website it is fetching information from is not avilable (e.g., Jenkins). This should not be the case. Instead, the launcher should once ping the server to check availability and gracefully continue startup in case the request fails.

  • add availability check before requestion game versions, build information, etc
  • skip additional requests if availability check fails (don't search for launcher updates or new versions)

Related to #429

@skaldarnar skaldarnar added this to Backlog in GSOC 2019: Launcher via automation Jun 17, 2019

@praj-foss praj-foss referenced this issue Jun 18, 2019

Merged

Check availability of Jenkins #434

3 of 4 tasks complete

GSOC 2019: Launcher automation moved this from Backlog to Done Jun 18, 2019

@skaldarnar skaldarnar reopened this Jun 18, 2019

GSOC 2019: Launcher automation moved this from Done to In progress Jun 18, 2019

@skaldarnar

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

Open task from #434: Skip syncing game versions when Jenkins is unavailable.

@praj-foss praj-foss self-assigned this Jul 2, 2019

@praj-foss praj-foss moved this from In progress to Backlog in GSOC 2019: Launcher Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.