Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Settings UI implementation #428

Open
wants to merge 6 commits into
base: develop
from

Conversation

3 participants
@praj-foss
Copy link
Member

commented Jun 5, 2019

Summary

Provides a new Settings menu porting all of the old UI features (except launcher update part), along with some small side-features.

Features included

  • New Settings menu with saving and loading functionality (Fixes #430)
  • Status bar with a progress indicator (Fixes a part of #426)
  • Gradle tasks to generate Web API client from Swagger specs (Fixes a part of #427)
  • Removed splash screen
  • LauncherInitTask starts before stage creation and updates UI upon completion

@praj-foss praj-foss added the GSoC 2019 label Jun 5, 2019

@praj-foss praj-foss self-assigned this Jun 5, 2019

@praj-foss praj-foss added this to In progress in GSOC 2019: Launcher via automation Jun 5, 2019

@praj-foss praj-foss requested a review from skaldarnar Jun 5, 2019

Show resolved Hide resolved .gitignore
Show resolved Hide resolved build.gradle
@skaldarnar

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

@GooeyHub ok to test

Support for new UI and Web API client generation
- Corrected gradle tasks for generating Web API client
- Loaded the new UI as default
- Removed splash screen and all old UI code

@praj-foss praj-foss moved this from In progress to Month 2 in GSOC 2019: Launcher Jun 12, 2019

praj-foss added some commits Jun 13, 2019

Added new Settings UI
- Designed FXML for the new Settings UI
- Added logging support in Main view and Server Manager
- Added licence headers to new FXML files
Enabled new Settings UI
- LauncherInitTask now starts before UI creation
- Ported all previous features of Settings menu
- Supported loading and saving of launcher settings
@GooeyHub

This comment has been minimized.

Copy link
Member

commented Jun 15, 2019

Hooray Jenkins reported success with all tests good!

Settings UI enhancements and status bar
- Added overlay on Settings UI to prevent mouse interaction while it updates
- Bound task message to status bar
- Added progress indicator on status bar
@GooeyHub

This comment has been minimized.

Copy link
Member

commented Jun 16, 2019

Hooray Jenkins reported success with all tests good!

@praj-foss praj-foss changed the title Server manager New Settings UI implementation Jun 16, 2019

@praj-foss praj-foss requested a review from skaldarnar Jun 16, 2019

This was referenced Jun 16, 2019

@praj-foss praj-foss moved this from Month 2 to In progress in GSOC 2019: Launcher Jun 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.