Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Settings UI #431

merged 1 commit into from Jun 17, 2019


4 participants
Copy link

commented Jun 17, 2019


Implements the new Settings menu UI. Fixes #430


Open the launcher and move over straight to the Settings menu. Test the UI, especially the Save and Cancel buttons. It should be able to save the configuration to, inside the launcher's data directory.



@praj-foss praj-foss self-assigned this Jun 17, 2019

@praj-foss praj-foss added the GSoC 2019 label Jun 17, 2019

@praj-foss praj-foss requested a review from skaldarnar Jun 17, 2019

@praj-foss praj-foss added this to In progress in GSOC 2019: Launcher via automation Jun 17, 2019


This comment has been minimized.

Copy link

commented Jun 17, 2019

Hooray Jenkins reported success with all tests good!

Copy link

left a comment

Looks fine, I'm merging this.

The manual check for updates is permanently greyed out and will be enabled later on, I guess?

@skaldarnar skaldarnar merged commit 1812a8a into develop Jun 17, 2019

1 check passed

default Build finished.

GSOC 2019: Launcher automation moved this from In progress to Done Jun 17, 2019

@skaldarnar skaldarnar deleted the feature/settings-menu branch Jun 17, 2019

@Cervator Cervator added this to the v4.0.0 - GSOC 2019 milestone Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.