Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundles a JRE with the Launcher package #441

Merged
merged 2 commits into from Jun 22, 2019

Conversation

@praj-foss
Copy link
Member

commented Jun 21, 2019

Summary

The final launcher distributions now bundle a given JRE. Fixes #438.

Testing

You will need a JRE build with JavaFX in it. Download from one of the following vendors:

Extract the downloaded files and use gradlew clean build -PbundleJre=/path/to/jre to generate the ZIP packages inside build/distributions. Try them in any system, it'll execute the bundled JRE only.

Roadmap

  • Add JRE to the generated packages
  • Fix *nix startup script
  • Fix windows startup script

@praj-foss praj-foss added the GSoC 2019 label Jun 21, 2019

@praj-foss praj-foss requested a review from skaldarnar Jun 21, 2019

@praj-foss praj-foss self-assigned this Jun 21, 2019

@praj-foss praj-foss added this to In progress in GSOC 2019: Launcher via automation Jun 21, 2019

@skaldarnar

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

How do I test this? Where do I get a JRE for bundling from? Could you please provide more information on how you tested it locally?

@praj-foss

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

How do I test this? Where do I get a JRE for bundling from? Could you please provide more information on how you tested it locally?

Added JRE links in the description. You can have a try 👍

@skaldarnar
Copy link
Member

left a comment

Tested on Mac with Azul Zulu and it works just fine!

@Cervator @jdrueckert Please confirm it working under Windows, too 🤞

@GooeyHub

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

Uh oh, something went wrong with the build. Need to check on that

1 similar comment
@GooeyHub

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

Uh oh, something went wrong with the build. Need to check on that

@Cervator

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

@GooeyHub: test this please

@GooeyHub

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

Uh oh, something went wrong with the build. Need to check on that

@Cervator

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

Okay think I've tested this out as well now, on Win10 👍

Grabbed the right JRE, pointed at it, grabbed the launcher zip. confirmed it had the jre dir in it, and tried to launch from a command prompt after "breaking" my PATH and JAVA_HOME - assuming the exe isn't smart enough to auto-detect it without those env vars.

I don't know why the testInitDefault unit test fails in Jenkins. Works fine locally both before and after this PR. Tried to run the dev build in Jenkins and it failed over javadoc, while the master build worked fine just a few days ago 🤔

We could probably merge this and try to work on Jenkins separately, maybe try it in the new Jenkins with a fresh new build job just to see how that differs.

@llvieira
Copy link
Member

left a comment

Tested it out on Linux Ubuntu and it works fine too. 👍

@skaldarnar skaldarnar merged commit 7bb42fe into develop Jun 22, 2019

1 check failed

default Build finished.
Details

GSOC 2019: Launcher automation moved this from In progress to Done Jun 22, 2019

@skaldarnar skaldarnar deleted the feature/bundled-jre branch Jun 22, 2019

@Cervator Cervator added this to the v4.0.0 - GSOC 2019 milestone Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.