Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the game run using the bundled JRE #444

Merged
merged 1 commit into from Jun 30, 2019

Conversation

@praj-foss
Copy link
Member

commented Jun 22, 2019

Summary

Uses the launcher's bundled JRE to start the game. Fixes #443.

Testing

  • Start the game from the launcher
  • Go to ExtrasMetrics MenuSystem Context
  • Check the details, it should be referring to the bundled JRE

@praj-foss praj-foss added the GSoC 2019 label Jun 22, 2019

@praj-foss praj-foss requested a review from skaldarnar Jun 22, 2019

@praj-foss praj-foss self-assigned this Jun 22, 2019

@praj-foss praj-foss added this to In progress in GSOC 2019: Launcher via automation Jun 22, 2019

@GooeyHub

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

Uh oh, something went wrong with the build. Need to check on that

@Cervator
Copy link
Member

left a comment

Tests out! Building the game with the embedded JRE steps then running the built version via .bat on Windows worked correctly. Running it via the .exe did not which needs to be a separate fix, probably just a new exe redirecting to the exe or something.

Old exe includes JRE auto-detection and such which we don't need anymore with this project complete. See https://github.com/MovingBlocks/TerasologyJavaLauncher/blob/master/terasology.cpp

@Cervator Cervator merged commit d80eff4 into develop Jun 30, 2019

1 check failed

default Build finished.
Details

GSOC 2019: Launcher automation moved this from In progress to Done Jun 30, 2019

Cervator added a commit that referenced this pull request Jun 30, 2019

@Cervator Cervator deleted the feature/fix-443 branch Jun 30, 2019

@Cervator Cervator added this to the v4.0.0 - GSOC 2019 milestone Jul 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.