Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure due to incorrect locale #449

Merged
merged 2 commits into from Jul 13, 2019

Conversation

@praj-foss
Copy link
Member

commented Jul 13, 2019

Summary

The last 13 TerasologyLauncherPRs builds have not been stable due to a test failure, which was caused by an improper state of Languages.java before running the test. This PR fixes things by resetting the state of that class after running TestLanguages.java. It also fixes some test names in the same class.

@praj-foss praj-foss added the Bug label Jul 13, 2019

@praj-foss praj-foss requested a review from Cervator Jul 13, 2019

@GooeyHub

This comment has been minimized.

Copy link
Member

commented Jul 13, 2019

Hooray Jenkins reported success with all tests good!

@Cervator
Copy link
Member

left a comment

Thanks for the detective work on this one! Tests out at least locally, going to let Jenkins have a(nother) go :-)

@Cervator Cervator merged commit 616d859 into develop Jul 13, 2019

1 check passed

default Build finished.
Details

@Cervator Cervator added this to the v4.0.0 - GSOC 2019 milestone Jul 13, 2019

@Cervator Cervator referenced this pull request Jul 14, 2019

@praj-foss praj-foss deleted the fix/locale-test branch Jul 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.