New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DON'T MERGE] Danger test. #17

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@sunshinejr
Member

sunshinejr commented Feb 21, 2018

This is for test purposes only (inline mode for danger-js/danger-swift/danger-swiftlint).

Todo:

@sunshinejr sunshinejr force-pushed the danger_test branch from baaa8c1 to f6845b5 Feb 21, 2018

sunshinejr added some commits Feb 25, 2018

@sunshinejr sunshinejr force-pushed the danger_test branch 6 times, most recently from be0397e to 49fe84f Feb 25, 2018

@Moya Moya deleted a comment from MoyaBot Feb 27, 2018

@sunshinejr sunshinejr force-pushed the danger_test branch from 49fe84f to eef5ff2 Mar 2, 2018

@Moya Moya deleted a comment from MoyaBot Mar 2, 2018

@sunshinejr sunshinejr force-pushed the danger_test branch from eef5ff2 to cdad7ff Mar 2, 2018

@Moya Moya deleted a comment from MoyaBot Mar 2, 2018

@AndrewSB

This comment has been minimized.

Member

AndrewSB commented Mar 3, 2018

@orta can @MoyaBot delete its old comment and redo its analysis every time theres a new commit/ amended commit?

@sunshinejr sunshinejr force-pushed the danger_test branch from cdad7ff to 32bf5d5 Mar 3, 2018

@sunshinejr

This comment has been minimized.

Member

sunshinejr commented Mar 3, 2018

Ok position finder seems to work 🎉

@orta

This comment has been minimized.

Member

orta commented Mar 3, 2018

@AndrewSB that's what danger does, it re-runs per CI run

@sunshinejr sunshinejr force-pushed the danger_test branch 3 times, most recently from 9288529 to c2547a0 Mar 4, 2018

@Moya Moya deleted a comment from MoyaBot Mar 4, 2018

@Moya Moya deleted a comment from MoyaBot Mar 4, 2018

@Moya Moya deleted a comment from MoyaBot Mar 4, 2018

@Moya Moya deleted a comment from MoyaBot Mar 4, 2018

@Moya Moya deleted a comment from MoyaBot Mar 4, 2018

@Moya Moya deleted a comment from MoyaBot Mar 4, 2018

@Moya Moya deleted a comment from MoyaBot Mar 4, 2018

@MoyaBot

This comment has been minimized.

MoyaBot commented Mar 9, 2018

Warnings
⚠️

Any changes to library code should be reflected in the Changelog.

Please consider adding a note there and adhere to the Changelog Guidelines.

Generated by 🚫 dangerJS

@SD10

This comment has been minimized.

Member

SD10 commented Mar 9, 2018

This is looking awesome @sunshinejr 💪

@Moya Moya deleted a comment from MoyaBot Mar 18, 2018

@Moya Moya deleted a comment from MoyaBot Mar 18, 2018

@Moya Moya deleted a comment from MoyaBot Mar 18, 2018

@Moya Moya deleted a comment from MoyaBot Mar 18, 2018

@sunshinejr sunshinejr force-pushed the danger_test branch from b8ab653 to b4ddd52 Mar 18, 2018

@sunshinejr sunshinejr force-pushed the danger_test branch from 1536bf4 to af32341 Mar 31, 2018

@sunshinejr sunshinejr referenced this pull request Mar 31, 2018

Merged

Inline mode #9

2 of 2 tasks complete

@Moya Moya deleted a comment from sunshinejr Apr 1, 2018

@sunshinejr sunshinejr force-pushed the danger_test branch from 60dba3b to af32341 Apr 1, 2018

@@ -16,5 +18,7 @@ public final class HarveyResponse {
self.data = data
self.statusCode = statusCode

This comment has been minimized.

@sunshinejr

sunshinejr Apr 1, 2018

Member

please don't delete this one, mr robot?

@Moya Moya deleted a comment from MoyaBot Apr 2, 2018

@Moya Moya deleted a comment from MoyaBot Apr 2, 2018

@@ -33,5 +33,5 @@ if onlyPodspec != onlyPackage {
}
// Workaround for SwiftLint bug https://github.com/ashfurrow/danger-swiftlint/issues/4
SwiftLint.lint(directory: "Sources", configFile: ".swiftlint.yml")
SwiftLint.lint(directory: "Tests", configFile: "Tests/HarveyTests/.swiftlint.yml")
SwiftLint.lint(inline: true, directory: "Sources", configFile: ".swiftlint.yml")

This comment has been minimized.

@sunshinejr

sunshinejr Apr 2, 2018

Member

Test inline comment to delete?

@Moya Moya deleted a comment from sunshinejr Apr 2, 2018

@Moya Moya deleted a comment from MoyaBot Apr 2, 2018

@Moya Moya deleted a comment from MoyaBot Apr 2, 2018

@Moya Moya deleted a comment from MoyaBot Apr 2, 2018

@@ -13,7 +13,7 @@ dependencies:
test:
override:
- swift build
- swift test

This comment has been minimized.

@sunshinejr
@@ -16,5 +18,7 @@ public final class HarveyResponse {
self.data = data
self.statusCode = statusCode
self.headers = headers
let _ = URL(string: "https://google.com")!

This comment has been minimized.

@MoyaBot

MoyaBot Apr 2, 2018

  • ⚠️ Prefer _ = foo() over let _ = foo() when discarding a result from a function.
@@ -8,6 +8,8 @@ public final class HarveyResponse {
public let headers: [String: String]?
// swiftlint:disable force_unwrapping

This comment has been minimized.

@MoyaBot

MoyaBot Apr 2, 2018

  • ⚠️ Lines should not have trailing whitespace.
@@ -8,6 +8,8 @@ public final class HarveyResponse {
public let headers: [String: String]?
// swiftlint:disable force_unwrapping

This comment has been minimized.

@MoyaBot

MoyaBot Apr 2, 2018

  • ⚠️ Limit vertical whitespace to a single empty line. Currently 2.
  • ⚠️ Lines should not have trailing whitespace.
@sunshinejr

This comment has been minimized.

Member

sunshinejr commented Apr 7, 2018

Closing this one as all of these are up and running and seems like most of the bugs are fixed as well. Now we can move to finally finishing Harvey 😉

@sunshinejr sunshinejr closed this Apr 7, 2018

@sunshinejr sunshinejr deleted the danger_test branch Apr 7, 2018

@sunshinejr sunshinejr restored the danger_test branch Apr 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment