New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Endpoint default arguments. #1289

Merged
merged 6 commits into from Sep 16, 2017

Conversation

Projects
None yet
5 participants
@sunshinejr
Member

sunshinejr commented Sep 15, 2017

Related: #1247, #1249 and #1253. I'm also using new Changelog guidelines which are in progress (here is the PR with it so you can discuss it), if anything we will just change the syntax later.

@sunshinejr sunshinejr added this to the 10.0 milestone Sep 15, 2017

@sunshinejr sunshinejr referenced this pull request Sep 15, 2017

Closed

Release 10.0 #1253

9 of 11 tasks complete
@pedrovereza

💯

@MoyaBot

This comment has been minimized.

Show comment
Hide comment
@MoyaBot

MoyaBot Sep 15, 2017

SwiftLint found issues

Warnings

File Line Reason
MoyaProviderSpec.swift 910 File should contain 400 lines or less: currently contains 910

Errors

File Line Reason
MoyaProviderSpec.swift 7 Type body should span 350 lines or less excluding comments and whitespace: currently spans 543 lines

Generated by 🚫 Danger

MoyaBot commented Sep 15, 2017

SwiftLint found issues

Warnings

File Line Reason
MoyaProviderSpec.swift 910 File should contain 400 lines or less: currently contains 910

Errors

File Line Reason
MoyaProviderSpec.swift 7 Type body should span 350 lines or less excluding comments and whitespace: currently spans 543 lines

Generated by 🚫 Danger

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 15, 2017

Codecov Report

Merging #1289 into 10.0.0-dev will increase coverage by 1.72%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##           10.0.0-dev   #1289      +/-   ##
=============================================
+ Coverage       81.27%     83%   +1.72%     
=============================================
  Files              24      24              
  Lines             753     753              
=============================================
+ Hits              612     625      +13     
+ Misses            141     128      -13
Impacted Files Coverage Δ
Sources/Moya/Endpoint.swift 92.3% <100%> (ø) ⬆️
Sources/Moya/Response.swift 95.65% <0%> (+8.69%) ⬆️
Sources/RxMoya/Observable+Response.swift 67.74% <0%> (+9.67%) ⬆️
Sources/ReactiveMoya/SignalProducer+Response.swift 90% <0%> (+10%) ⬆️
Sources/RxMoya/Single+Response.swift 100% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 494ff5c...62be9b2. Read the comment docs.

codecov-io commented Sep 15, 2017

Codecov Report

Merging #1289 into 10.0.0-dev will increase coverage by 1.72%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##           10.0.0-dev   #1289      +/-   ##
=============================================
+ Coverage       81.27%     83%   +1.72%     
=============================================
  Files              24      24              
  Lines             753     753              
=============================================
+ Hits              612     625      +13     
+ Misses            141     128      -13
Impacted Files Coverage Δ
Sources/Moya/Endpoint.swift 92.3% <100%> (ø) ⬆️
Sources/Moya/Response.swift 95.65% <0%> (+8.69%) ⬆️
Sources/RxMoya/Observable+Response.swift 67.74% <0%> (+9.67%) ⬆️
Sources/ReactiveMoya/SignalProducer+Response.swift 90% <0%> (+10%) ⬆️
Sources/RxMoya/Single+Response.swift 100% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 494ff5c...62be9b2. Read the comment docs.

@SD10

SD10 approved these changes Sep 16, 2017

@sunshinejr sunshinejr merged commit 8034515 into 10.0.0-dev Sep 16, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@sunshinejr sunshinejr deleted the feature/remove-endpoint-default-parameters branch Sep 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment