New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkActivityPlugin to have target in networkActivityClosure. #1290

Merged
merged 6 commits into from Sep 16, 2017

Conversation

Projects
None yet
4 participants
@sunshinejr
Member

sunshinejr commented Sep 15, 2017

Related: #1184 and #1253. I'm also using new Changelog guidelines which are in progress (here is the PR with it so you can discuss it), if anything we will just change the syntax later.

@sunshinejr sunshinejr added this to the 10.0 milestone Sep 15, 2017

@sunshinejr sunshinejr referenced this pull request Sep 15, 2017

Closed

Release 10.0 #1253

9 of 11 tasks complete
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 15, 2017

Codecov Report

Merging #1290 into 10.0.0-dev will decrease coverage by 1.72%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           10.0.0-dev    #1290      +/-   ##
==============================================
- Coverage          83%   81.27%   -1.73%     
==============================================
  Files              24       24              
  Lines             753      753              
==============================================
- Hits              625      612      -13     
- Misses            128      141      +13
Impacted Files Coverage Δ
Sources/Moya/Plugins/NetworkActivityPlugin.swift 100% <100%> (ø) ⬆️
Sources/RxMoya/Single+Response.swift 85.71% <0%> (-14.29%) ⬇️
Sources/ReactiveMoya/SignalProducer+Response.swift 80% <0%> (-10%) ⬇️
Sources/RxMoya/Observable+Response.swift 58.06% <0%> (-9.68%) ⬇️
Sources/Moya/Response.swift 86.95% <0%> (-8.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8034515...9755f4b. Read the comment docs.

codecov-io commented Sep 15, 2017

Codecov Report

Merging #1290 into 10.0.0-dev will decrease coverage by 1.72%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           10.0.0-dev    #1290      +/-   ##
==============================================
- Coverage          83%   81.27%   -1.73%     
==============================================
  Files              24       24              
  Lines             753      753              
==============================================
- Hits              625      612      -13     
- Misses            128      141      +13
Impacted Files Coverage Δ
Sources/Moya/Plugins/NetworkActivityPlugin.swift 100% <100%> (ø) ⬆️
Sources/RxMoya/Single+Response.swift 85.71% <0%> (-14.29%) ⬇️
Sources/ReactiveMoya/SignalProducer+Response.swift 80% <0%> (-10%) ⬇️
Sources/RxMoya/Observable+Response.swift 58.06% <0%> (-9.68%) ⬇️
Sources/Moya/Response.swift 86.95% <0%> (-8.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8034515...9755f4b. Read the comment docs.

@MoyaBot

This comment has been minimized.

Show comment
Hide comment
@MoyaBot

MoyaBot Sep 16, 2017

SwiftLint found issues

Warnings

File Line Reason
MoyaProviderSpec.swift 918 File should contain 400 lines or less: currently contains 918
TestHelpers.swift 55 Operators should be surrounded by a single whitespace when defining them.

Errors

File Line Reason
MoyaProviderSpec.swift 7 Type body should span 350 lines or less excluding comments and whitespace: currently spans 549 lines

Generated by 🚫 Danger

MoyaBot commented Sep 16, 2017

SwiftLint found issues

Warnings

File Line Reason
MoyaProviderSpec.swift 918 File should contain 400 lines or less: currently contains 918
TestHelpers.swift 55 Operators should be surrounded by a single whitespace when defining them.

Errors

File Line Reason
MoyaProviderSpec.swift 7 Type body should span 350 lines or less excluding comments and whitespace: currently spans 549 lines

Generated by 🚫 Danger

@SD10

SD10 approved these changes Sep 16, 2017

LGTM. Just curious, did the stale bot closing the issue about this remind you that we could add it to 10.0?

@sunshinejr

This comment has been minimized.

Show comment
Hide comment
@sunshinejr

sunshinejr Sep 16, 2017

Member

@SD10 maybe, do not remember honestly 😄 I was selecting tasks from 10.0.0 release that I can do on the train and these two PRs were easy to do so.

Member

sunshinejr commented Sep 16, 2017

@SD10 maybe, do not remember honestly 😄 I was selecting tasks from 10.0.0 release that I can do on the train and these two PRs were easy to do so.

@SD10

This comment has been minimized.

Show comment
Hide comment
@SD10

SD10 Sep 16, 2017

Member

Unrelated to the PR:
@sunshinejr I tried tackling some of the 10.0 tasks yesterday but was having trouble building the project + it's dependencies. I'm going to try again tonight. I should just have to switch to the 10.0.0-dev branch and run carthage bootstrap again?

Member

SD10 commented Sep 16, 2017

Unrelated to the PR:
@sunshinejr I tried tackling some of the 10.0 tasks yesterday but was having trouble building the project + it's dependencies. I'm going to try again tonight. I should just have to switch to the 10.0.0-dev branch and run carthage bootstrap again?

@sunshinejr

This comment has been minimized.

Show comment
Hide comment
@sunshinejr

sunshinejr Sep 16, 2017

Member

Yup, should work just fine 👍

Member

sunshinejr commented Sep 16, 2017

Yup, should work just fine 👍

@sunshinejr sunshinejr merged commit d5d1c0c into 10.0.0-dev Sep 16, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@sunshinejr sunshinejr deleted the feature/network_activity_plugin_improvements branch Sep 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment