Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Removed] RxMoyaProvider and ReactiveSwiftMoyaProvider #1320
@@ Coverage Diff @@ ## 10.0.0-dev #1320 +/- ## ============================================== + Coverage 85.67% 87.09% +1.41% ============================================== Files 24 22 -2 Lines 768 736 -32 ============================================== - Hits 658 641 -17 + Misses 110 95 -15
referenced this pull request
Sep 27, 2017
Thanks for the work, @SD10! One thing that I didn't say before is that with removal of reactive providers we don't need additional abstraction over reactive methods (we needed these as we shared code (e.g.
could you fix these 2 linting issues as well?
@sunshinejr I'm a little confused about the refactoring that needs to be done to remove the two abstractions. It requires I prefix all
I tried moving the methods back into
Feel free to take over if you'd like