New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that decodable mapping won't decode nested json array #1382

Merged
merged 1 commit into from Oct 21, 2017

Conversation

Projects
None yet
7 participants
@devxoul
Member

devxoul commented Oct 18, 2017

Fixes #1381

@MoyaBot

This comment has been minimized.

Show comment
Hide comment
@MoyaBot

MoyaBot Oct 18, 2017

2 Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there and adhere to the Changelog Guidelines.
⚠️ Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

SwiftLint found issues

Warnings

File Line Reason
Observable+MoyaSpec.swift 6 Type body should span 200 lines or less excluding comments and whitespace: currently spans 241 lines
SignalProducer+MoyaSpec.swift 10 Type body should span 200 lines or less excluding comments and whitespace: currently spans 225 lines
Single+MoyaSpec.swift 6 Type body should span 200 lines or less excluding comments and whitespace: currently spans 229 lines

Generated by 🚫 Danger

MoyaBot commented Oct 18, 2017

2 Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there and adhere to the Changelog Guidelines.
⚠️ Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

SwiftLint found issues

Warnings

File Line Reason
Observable+MoyaSpec.swift 6 Type body should span 200 lines or less excluding comments and whitespace: currently spans 241 lines
SignalProducer+MoyaSpec.swift 10 Type body should span 200 lines or less excluding comments and whitespace: currently spans 225 lines
Single+MoyaSpec.swift 6 Type body should span 200 lines or less excluding comments and whitespace: currently spans 229 lines

Generated by 🚫 Danger

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 18, 2017

Codecov Report

Merging #1382 into 10.0.0-dev will increase coverage by 2.06%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           10.0.0-dev    #1382      +/-   ##
==============================================
+ Coverage       86.35%   88.41%   +2.06%     
==============================================
  Files              24        5      -19     
  Lines             784      164     -620     
==============================================
- Hits              677      145     -532     
+ Misses            107       19      -88
Impacted Files Coverage Δ
Sources/Moya/Endpoint.swift
Sources/Moya/AnyEncodable.swift
Sources/Moya/MoyaProvider.swift
Sources/Moya/TargetType.swift
Sources/Moya/MoyaProvider+Defaults.swift
Sources/Moya/MoyaError.swift
Sources/Moya/Cancellable.swift
Sources/Moya/MultipartFormData.swift
Sources/Moya/MoyaProvider+Internal.swift
Sources/Moya/URLRequest+Encoding.swift
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e536e...eb05f5a. Read the comment docs.

codecov-io commented Oct 18, 2017

Codecov Report

Merging #1382 into 10.0.0-dev will increase coverage by 2.06%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           10.0.0-dev    #1382      +/-   ##
==============================================
+ Coverage       86.35%   88.41%   +2.06%     
==============================================
  Files              24        5      -19     
  Lines             784      164     -620     
==============================================
- Hits              677      145     -532     
+ Misses            107       19      -88
Impacted Files Coverage Δ
Sources/Moya/Endpoint.swift
Sources/Moya/AnyEncodable.swift
Sources/Moya/MoyaProvider.swift
Sources/Moya/TargetType.swift
Sources/Moya/MoyaProvider+Defaults.swift
Sources/Moya/MoyaError.swift
Sources/Moya/Cancellable.swift
Sources/Moya/MultipartFormData.swift
Sources/Moya/MoyaProvider+Internal.swift
Sources/Moya/URLRequest+Encoding.swift
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e536e...eb05f5a. Read the comment docs.

Show outdated Hide outdated Sources/Moya/Response.swift Outdated
@sunshinejr

Thanks @devxoul! Also, don't worry that you forgot about it, we all didn't see it while doing CR. This feature consisted of many additional checks so missing one is something easy to do. I'm going to leave this open for another pair of eyes, though!

@sunshinejr sunshinejr referenced this pull request Oct 18, 2017

Closed

RxSwift4.0 #1379

Show outdated Hide outdated Tests/Observable+MoyaSpec.swift Outdated
@sunshinejr

This comment has been minimized.

Show comment
Hide comment
@sunshinejr

sunshinejr Oct 20, 2017

Member

@devxoul would you rebase it so we can merge this one in? 😉

Member

sunshinejr commented Oct 20, 2017

@devxoul would you rebase it so we can merge this one in? 😉

@devxoul

This comment has been minimized.

Show comment
Hide comment
@devxoul
Member

devxoul commented Oct 20, 2017

@sunshinejr Sure!

@SD10

SD10 approved these changes Oct 20, 2017 edited

Great work 👍 Love having more tests

@SD10

This comment has been minimized.

Show comment
Hide comment
@SD10

SD10 Oct 21, 2017

Member

SD10 Bot Has Commented 😂:

❌ fatal error: URLEncoding is disallowed as bodyEncoding.: file /Users/distiller/Moya/Sources/Moya/Endpoint.swift, line 95

Member

SD10 commented Oct 21, 2017

SD10 Bot Has Commented 😂:

❌ fatal error: URLEncoding is disallowed as bodyEncoding.: file /Users/distiller/Moya/Sources/Moya/Endpoint.swift, line 95

@sunshinejr sunshinejr merged commit 9e88321 into Moya:10.0.0-dev Oct 21, 2017

1 check failed

ci/circleci Your tests failed on CircleCI
Details

@devxoul devxoul deleted the devxoul:decodable-keypath branch Oct 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment