New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ReactiveSwift to 3.0 #1470

Merged
merged 3 commits into from Nov 29, 2017

Conversation

Projects
None yet
5 participants
@larryonoff
Contributor

larryonoff commented Nov 18, 2017

Fixes #1468
This PR contains ReactiveSwift update to 3.0

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 18, 2017

Codecov Report

Merging #1470 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1470   +/-   ##
============================================
  Coverage        87.82%   87.82%           
============================================
  Files                5        5           
  Lines              156      156           
============================================
  Hits               137      137           
  Misses              19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e729b3a...2edb074. Read the comment docs.

codecov-io commented Nov 18, 2017

Codecov Report

Merging #1470 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1470   +/-   ##
============================================
  Coverage        87.82%   87.82%           
============================================
  Files                5        5           
  Lines              156      156           
============================================
  Hits               137      137           
  Misses              19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e729b3a...2edb074. Read the comment docs.

@SD10

This comment has been minimized.

Show comment
Hide comment
@SD10

SD10 Nov 18, 2017

Member

We may have to update the Package.swift as well. I'm also unsure if this should go into master or development. If master, we could do a minor patch release including the bugfixes we've merged.

Member

SD10 commented Nov 18, 2017

We may have to update the Package.swift as well. I'm also unsure if this should go into master or development. If master, we could do a minor patch release including the bugfixes we've merged.

@SD10 SD10 referenced this pull request Nov 18, 2017

Closed

Release 10.0.1 #1471

@SD10

SD10 approved these changes Nov 18, 2017

@larryonoff Nit but can you take care of the linting errors?

@larryonoff

This comment has been minimized.

Show comment
Hide comment
@larryonoff

larryonoff Nov 18, 2017

Contributor

@SD10 sure! Better in this PR or separate ?

Contributor

larryonoff commented Nov 18, 2017

@SD10 sure! Better in this PR or separate ?

@larryonoff

This comment has been minimized.

Show comment
Hide comment
@larryonoff

larryonoff Nov 18, 2017

Contributor

Some linter errors fixed in a separate PR #1473

Contributor

larryonoff commented Nov 18, 2017

Some linter errors fixed in a separate PR #1473

@larryonoff

This comment has been minimized.

Show comment
Hide comment
@larryonoff

larryonoff Nov 20, 2017

Contributor

Closed separate PR with linter fixes and made the change in the current only

Contributor

larryonoff commented Nov 20, 2017

Closed separate PR with linter fixes and made the change in the current only

@SD10 SD10 changed the base branch from master to development Nov 20, 2017

@SD10

This comment has been minimized.

Show comment
Hide comment
@SD10

SD10 Nov 20, 2017

Member

I've changed this from master to development because this change will go into Moya 11.0. The excess commits look scary but it's only because we need to merge the commits currently on master into development. Then they should all disappear.

Member

SD10 commented Nov 20, 2017

I've changed this from master to development because this change will go into Moya 11.0. The excess commits look scary but it's only because we need to merge the commits currently on master into development. Then they should all disappear.

@sunshinejr

This comment has been minimized.

Show comment
Hide comment
@sunshinejr

sunshinejr Nov 28, 2017

Member

Hey @larryonoff, could you rebase your PR, please? I think we will be looking at new major version in the near future 😉

Member

sunshinejr commented Nov 28, 2017

Hey @larryonoff, could you rebase your PR, please? I think we will be looking at new major version in the near future 😉

@larryonoff

This comment has been minimized.

Show comment
Hide comment
@larryonoff

larryonoff Nov 29, 2017

Contributor

@sunshinejr Just rebased PR to development branch.

Contributor

larryonoff commented Nov 29, 2017

@sunshinejr Just rebased PR to development branch.

@sunshinejr

This comment has been minimized.

Show comment
Hide comment
@sunshinejr

sunshinejr Nov 29, 2017

Member

Cool, thanks @larryonoff! Can you just add an entry to Changelog? Here you can find some guidelines for that (this is also a breaking change).

Member

sunshinejr commented Nov 29, 2017

Cool, thanks @larryonoff! Can you just add an entry to Changelog? Here you can find some guidelines for that (this is also a breaking change).

@larryonoff

This comment has been minimized.

Show comment
Hide comment
@larryonoff

larryonoff Nov 29, 2017

Contributor

@sunshinejr done. hope that according guidelines.

I'm thinking about making ReactiveMoya as something separate from main Moya project. So that we're able updating it independently.

Contributor

larryonoff commented Nov 29, 2017

@sunshinejr done. hope that according guidelines.

I'm thinking about making ReactiveMoya as something separate from main Moya project. So that we're able updating it independently.

Show outdated Hide outdated Changelog.md Outdated

@lucas34 lucas34 self-requested a review Nov 29, 2017

@sunshinejr

Thank you very much @larryonoff! 🎉

@sunshinejr sunshinejr merged commit 9ef1460 into development Nov 29, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@sunshinejr sunshinejr deleted the bump-reactive-swift branch Nov 29, 2017

larryonoff added a commit that referenced this pull request Dec 3, 2017

@larryonoff larryonoff referenced this pull request Dec 3, 2017

Merged

Bugfix changelog #1489

@lucas34

This comment has been minimized.

Show comment
Hide comment
@lucas34

lucas34 Jan 6, 2018

Member

Package.Resolved has not been updated. It's still pointing to 2.0.1.
Should run 'swift package update'
I created a PR #1531 for this

Member

lucas34 commented Jan 6, 2018

Package.Resolved has not been updated. It's still pointing to 2.0.1.
Should run 'swift package update'
I created a PR #1531 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment