New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter violations #1473

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@larryonoff
Contributor

larryonoff commented Nov 18, 2017

No description provided.

@larryonoff

This comment has been minimized.

Contributor

larryonoff commented Nov 18, 2017

What about disabling some linter rules specifically for spec files?

@codecov-io

This comment has been minimized.

codecov-io commented Nov 18, 2017

Codecov Report

Merging #1473 into master will increase coverage by 5.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1473      +/-   ##
==========================================
+ Coverage   82.92%   88.41%   +5.48%     
==========================================
  Files           5        5              
  Lines         164      164              
==========================================
+ Hits          136      145       +9     
+ Misses         28       19       -9
Impacted Files Coverage Δ
Sources/RxMoya/Observable+Response.swift 70.58% <0%> (+8.82%) ⬆️
Sources/ReactiveMoya/SignalProducer+Response.swift 90.9% <0%> (+9.09%) ⬆️
Sources/RxMoya/Single+Response.swift 100% <0%> (+12.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea236dc...346148d. Read the comment docs.

endpoint = endpoint.replacing(task: .requestParameters(parameters: ["":InvalidParameter()], encoding: PropertyListEncoding.default))
let cocoaError = NSError(domain: "NSCocoaErrorDomain", code: 3851, userInfo: ["NSDebugDescription":"Property list invalid for format: 100 (property lists cannot contain objects of type 'CFType')"])
endpoint = endpoint.replacing(
task: .requestParameters(

This comment has been minimized.

@SD10

SD10 Nov 18, 2017

Member

Just fixing the ones in Package.swift would've been ok... no need for a separate PR 😓
Now this misalignment is killing my OCD

@larryonoff larryonoff closed this Nov 18, 2017

@larryonoff larryonoff deleted the fix-linter-violations branch Nov 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment