New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raised ReactiveSwift version dependency 2.0 -> 3.0 #1476

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@DrewKiino

DrewKiino commented Nov 20, 2017

raised version to allow Swift 4 builds using subspecs and third-party dependencies such as https://github.com/ivanbruel/Moya-ObjectMapper which requires ReactiveSwift (3.0.0) and ReactiveCocoa (7.0.0)

@MoyaBot

This comment has been minimized.

MoyaBot commented Nov 20, 2017

1 Warning
⚠️ The podspec was updated, but there were no changes in either the Cartfile nor Cartfile.resolved. Did you forget updating Cartfile or Cartfile.resolved?

Generated by 🚫 Danger

@codecov-io

This comment has been minimized.

codecov-io commented Nov 20, 2017

Codecov Report

Merging #1476 into master will increase coverage by 5.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1476      +/-   ##
==========================================
+ Coverage   82.92%   88.41%   +5.48%     
==========================================
  Files           5        5              
  Lines         164      164              
==========================================
+ Hits          136      145       +9     
+ Misses         28       19       -9
Impacted Files Coverage Δ
Sources/RxMoya/Observable+Response.swift 70.58% <0%> (+8.82%) ⬆️
Sources/ReactiveMoya/SignalProducer+Response.swift 90.9% <0%> (+9.09%) ⬆️
Sources/RxMoya/Single+Response.swift 100% <0%> (+12.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea236dc...c7f1e23. Read the comment docs.

@SD10

This comment has been minimized.

Member

SD10 commented Nov 21, 2017

Hey @DrewKiino, I'm going to close this because it's a duplicate of #1470. But thank you for taking the time to make this pull request 👍

@SD10 SD10 closed this Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment