New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run SwiftLint only on debug builds #1619

Merged
merged 5 commits into from Apr 1, 2018

Conversation

Projects
None yet
5 participants
@Dschee
Contributor

Dschee commented Mar 30, 2018

Attempts to fix problems with the SwiftLint script when building via Carthage.

Fixes #1458 and #1542. Intended to supersede #1615.
Related to #1616.

Run SwiftLint only on debug builds
Attempt to fix issues when building this with Carthage.
See #1616 for more details.
@MoyaBot

This comment has been minimized.

MoyaBot commented Mar 30, 2018

1 Warning
⚠️ Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

Generated by 🚫 Danger

@codecov-io

This comment has been minimized.

codecov-io commented Mar 30, 2018

Codecov Report

Merging #1619 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1619   +/-   ##
=======================================
  Coverage   87.82%   87.82%           
=======================================
  Files           5        5           
  Lines         156      156           
=======================================
  Hits          137      137           
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bdb72b...f68f5ca. Read the comment docs.

@sunshinejr

This comment has been minimized.

Member

sunshinejr commented Mar 30, 2018

I appreciate that you jumped in on this, @Dschee. However, we don't want to make the same mistake twice and just believe that this is working. Could you please create a step in Circle CI config that runs carthage script without SwiftLint installed?

@Dschee

This comment has been minimized.

Contributor

Dschee commented Mar 31, 2018

I just added something to the Circle CI config. Let's see what the result's gonna be ...

@Dschee

This comment has been minimized.

Contributor

Dschee commented Mar 31, 2018

The new step running this before SwiftLint install:

carthage build --no-skip-current --cache-builds

Resulted in a successful build of all Moya targets:

*** Building scheme "Moya" in Moya.xcodeproj
*** Building scheme "RxMoya" in Moya.xcodeproj
*** Building scheme "ReactiveMoya" in Moya.xcodeproj

@sunshinejr Does this meet your expectations?

@SD10

This comment has been minimized.

Member

SD10 commented Mar 31, 2018

@Dschee Thanks for finding an alternative solution to removing part of our tooling

@Dschee

This comment has been minimized.

Contributor

Dschee commented Mar 31, 2018

Just as a side note: I had similar issues with SwiftLint and Carthage like I saw in several issues here in my own open source projects. This approach successfully fixed them all. That‘s why when I saw you were removing SwiftLint I felt like I should share my experience there.

@SD10

SD10 approved these changes Apr 1, 2018

:shipit: ⛵️

@SD10 SD10 merged commit 85f2a1c into master Apr 1, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@SD10 SD10 deleted the swiftlint-fix branch Apr 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment